Repository navigation
quest: plan follow-ups of the 2026-11-04 merges - #45
Conversation
Five m0 fixes (clean quit, recording repair, premultiplied sampling, deterministic CEF startup, first-page renderer death) and four m1 features (overlay restart, overlay assets, global hotkeys, isolated guest recordings). m1's goal broadens to work held until m0 ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 143db3c
- [P2] Premultiply before interpolation (
quest/m0/premultiply.md:16–17). The plan treats setting the effect pass's premultiplied flag as an alternative to converting the upload. The shader samples first and the flag only divides the sampled RGB by alpha, so it cannot remove fringe color contributed by transparent texels. Require premultiplying before interpolation and set the flag consistently; a shader alternative would need to premultiply each tap before filtering.
The follow-up plans otherwise provide a useful, focused way to carry forward the merge decisions.
Verification: GitHub-only static review of the plans and referenced code. I did not run builds, tests or GPU execution.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Two plan gaps would lead to wrong behavior: a repaired recording is repaired again on every launch, and the premultiply plan offers a flag that cannot remove the edge fringe.
Reviewed changes
Reviewed the nine new quest files and the two milestone index updates, checking their structure and code references against the pinned quest guide and moq pin; the quest CLI is unavailable here, so quest check was not run.
- New m0 fixes:
clean-quit,recording-repair,premultiply,cef-startup, andbrowser-first-crash, linked from the m0 index at the decided rank. - New m1 features:
overlay-restart,overlay-assets,hotkeys, andguest-recording, linked from the m1 index. - m1 broadened: the milestone is retitled "after the studio ships" and its Goal and Plan record the 2026-11-04 decision to hold those features rather than open an m2.
⚠️ The root milestone index still calls m1 "viewers compose"
quest/m1/README.md now titles the milestone "after the studio ships" and its Goal adds overlay assets and restarts, global hotkeys, and isolated guest recordings, but quest/README.md:22 still lists it as "m1: viewers compose" with only the viewer-side-composition summary. The pinned quest guide requires a scope change to update the parent index, and #30 updated this line when it created m1. Update the title and one-liner there so the milestone list matches the milestone it links.
Technical details
# Stale m1 entry in the root quest index
## Affected sites
- `quest/README.md:22` — links m1 as "m1: viewers compose" and describes only viewer-side composition.
## Required outcome
- The root entry names the broadened milestone (for example "m1: after the studio ships") and its one-liner covers the new feature quests, or at least points at the m1 README's broadened Goal, rather than describing viewer-side composition as the whole milestone.
## Suggested approach (optional)
- Mirror `quest/m1/README.md`'s title, and open the description with viewer-side composition as one child before the added features.big-pickle (free) ｜ 𝕏
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Important
The new commit fixes both prior inline findings correctly, but the earlier note about the stale m1 entry in the root quest index is still unaddressed.
Reviewed changes
Re-reviewed the one commit since the prior pullfrog review (143db3c → f9a5641), which touches only quest/m0/premultiply.md and quest/m0/recording-repair.md.
- Reworded the premultiply plan to require premultiplying before interpolation, and to call out that the effect pass's
premultipliedflag runs afterfetch()'s bilinear sample, so the flag alone cannot remove the fringe. Matchesrs/moq-scene/src/effect.wgsl:83-99. - Reworked the recording-repair plan to use a
<name>.mp4.partsidecar written at start and deleted at finish, with launch deleting it once<name>.repaired.mp4is written, so a file is never repaired twice and the original keeps its name.
⚠️ The root milestone index still calls m1 "viewers compose"
quest/m1/README.md is retitled "after the studio ships" and its Goal adds overlay assets and restarts, global hotkeys, and isolated guest recordings, but quest/README.md:22 still lists m1 as "viewers compose" with only the viewer-side-composition summary. The pinned quest guide requires a scope change to update the parent index, and f9a5641 does not touch that line.
Technical details
# Stale m1 entry in the root quest index
## Affected sites
- `quest/README.md:22` — links m1 as "m1: viewers compose" and describes only viewer-side composition.
## Required outcome
- The root entry names the broadened milestone (for example "m1: after the studio ships") and its one-liner covers the new feature quests, or at least points at the m1 README's broadened Goal.
## Suggested approach (optional)
- Mirror `quest/m1/README.md`'s title, and open the description with viewer-side composition as one child before the added features.big-pickle (free) ｜ 𝕏
Plans the follow-ups that landed PRs suggested, picked with the maintainer through
/quest-planon 2026-11-04.New quests
m0, after the feature quests and before signing (fixes):
m1, whose goal broadens to "after the studio ships" (features):
Decisions
Picked follow-ups (the rest were dropped):
Milestone: all m0 at the end; ✅ fixes m0, features m1.
m1's goal: ✅ broaden it; new m2; put them in m0.
Hotkey scope: focused first, global later; ✅ global in this quest; focused only.
Hotkey defaults: ✅ none bound; a few defaults.
CEF GPU: ✅
--disable-gpuon the CPU path; package GL for CEF.Repair: ✅ repair automatically, keep original; repair in place; ask first.
Overlay assets: ✅ local files +
data:only; also https.Overlay restart: ✅ per overlay, default on; always restart.
Guest recordings: ✅ extend "each source"; separate guest toggle.
moq-side follow-ups stay out of the tree, held with the other deferred moq quests.
Review
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)