Repository navigation
feat: run quest context always and quest guide only for quest work - #460
Merged
Merged
Conversation
The guide held rules every task needs (workspace, questions, reviews) beside quest mechanics, so agents read all of it before any work. Move the generic sections, plus the guide's generic pull request rules, into `quest context` with a short quest primer that says when to run `quest guide`. `quest init` now points agents only at `quest context`, upgrading both earlier defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
There was a problem hiding this comment.
ℹ️ No critical issues — minor suggestions below.
Reviewed changes — one commit:
- Context/guide split (
assets/AGENTS.md,assets/CONTEXT.md):Workspace,Questions, andReviewsmove toquest contextverbatim, with a newPull requestssection carrying the push rules the guide previously held inline, and aQuestsprimer pointing quest work atquest guide. The "end every quest skill with a summary" rule gains its own## Summariesheading in the guide. - Consistent cross-references: every skill citation of the guide's moved sections now names
quest context, and I found no stale section anchors left inassets/, the skills, or the docs. quest initreference line (src/core/init.ts):REFERENCE_LINEdropsquest guide, and both prior default lines retire intoOLD_REFERENCE_LINESfor in-place upgrade; init tests pass (49/49).- Non-code: the runner already embeds context and guide together in full (
src/runner/prompt.ts:109), so no behavioral change; README and the Cloudflare setup-PR purpose line updated to match.
ℹ️ Stale "guide's" pointers the split leaves behind
Technical details
# Stale "guide's" pointers after the Context/guide split
## Affected sites
- `src/runner/job.ts:505` — the review-findings note tells the agent to "Follow the guide's review rules, including its design checkpoint every fourth round." The review rules and the design checkpoint now live in `quest context` (`assets/CONTEXT.md`'s Reviews section), not the guide.
- `src/cli/main.ts:1182` — `quest guide --help` still prints "Print the quest guide: the format, workflow, and rules agents follow", which describes the pre-split scope; the README now describes `quest guide` as "the quest format and workflow".
## Required outcome
- The runner note and the `quest guide` description point readers at where the content actually lives now.
## Suggested approach (optional)
- `src/runner/prompt.ts:9` embeds both files in full, so nothing breaks — this is page-not-founding within a prompt, not dead code. Reword the job note to `quest context`'s review rules, and align the command description with the README's wording.
## Open questions for the human (optional)ℹ️ The newly retired reference line has no upgrade test
Technical details
# Reference-line upgrade test misses the line #460 retires
## Affected sites
- `test/init.test.ts:247` — "init upgrades an earlier release's default reference line" still fixtures only the oldest line ("run `quest guide` and follow it"). The line this PR retires, "run `quest context` and `quest guide`, and follow both", is the one most installed bases currently hold, and is covered only indirectly via the shared `OLD_REFERENCE_LINES` mechanism in `appendLine` (`src/core/init.ts:231`).
## Required outcome
- The upgrade test exercises the second entry too, ideally with both entries in the fixture list order, to pin that the in-place replace keeps writing the newest line.
## Suggested approach (optional)
- Extend the existing fixture (or add a sibling test) writing the retired context-and-guide line and asserting it becomes `REFERENCE_LINE`.
- Unverified but fine to ignore: the fixture uses CRLF, which matches the newline-preservation branch of `appendLine`; a second fixture can reuse it.
## Open questions for the human (optional)glm-5.3-flash | 𝕏
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Agents should run
quest contextbefore every task andquest guideonly for quest work. The guide still held sections every task needs, so this moves them:quest context:quest guide, and that follow-ups become quests through/quest-planquest contextfor everything else.quest initwritesQuests: before any work, run \quest context` and follow it.` and upgrades both earlier default lines in place.quest context.Word counts:
The quest number is unchanged except for the new primer.
Follows #457 (#457).
Impact
quest guideno longer contains Workspace, Questions, or Reviews; they're inquest context. Anything linkingassets/AGENTS.md#workspaceshould linkassets/CONTEXT.md#workspace.REFERENCE_LINEchanged;quest initupgrades the earlier defaults.Follow-ups
quest contextfor shared engineering rules #457 will switch to the new line and bump quest to this commit once it lands: docs(agents): rely on quest context for shared rules moq#7761, moq-dev/kixel.ai#10, docs(agents): rely on quest context for shared rules moq.dev#215, moq-dev/moq.pro#3424, docs(agents): rely on quest context for shared rules rind#305, docs(agents): rely on quest context for shared rules rust2#553, docs(agents): rely on quest context for shared rules studio#26.Validation
just checkpasses.bun run testpasses: 28 files, 1042 tests.cloudflare/test/setup.test.tspasses: 15 tests.Review
quest review --base origin/main.105b126c55548dec6d3766f8484dedc0dbdffffa.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)