[kixelated]

Summary

moq-dev/quest#457 added quest context, which prints the shared engineering rules plus a Prompting section. This makes rust2 rely on it instead of carrying copies:

• AGENTS.md keeps only the rules specific to rust2 (source-span errors, exact semantics proven by differential tests, stock crates without config, moq as first consumer, upstream crates first, MIGRATE.md entries) and the just commands, and tells agents to run quest context and quest guide before starting work.
• PROMPTING.md is removed; .claude/rules/prompting.md now points at Prompting in quest context. No other tracked file referenced PROMPTING.md.
• flake.nix bumps the pinned quest rev from dc8008bc to 9277dc34 (current quest main), with flake.lock updated by nix flake update quest. The input is pinned by rev in flake.nix, so the lock alone could not move it.

Every dropped rule is covered by quest context or quest guide, or is generic rather than rust2-specific. A few generic rules have no exact upstream equivalent and were dropped anyway, as candidates for quest's CONTEXT.md if wanted: "match existing conventions, patterns, and naming", "never pass a flaky test by loosening its assertion", "recognize when you're stuck and stop early", "short names under a module namespace", and "keep the PR to one problem, no drive-by changes" (partly covered by the guide's exhaustive-solution and follow-up rules).

Impact

Docs and tooling only: no public API or wire change. The dev shell's quest moves to 9277dc34.

Validation

• nix develop --command quest context prints the context.
• nix develop --command just ci: exit 0 (the flake change selected every module: lint, quest, uniffi, driver, ffi, go, ts checks and tests).

Review

• cf0736bc7d3f254f68a1982bda9d3807b8717d29: review skipped by the author as trivial (the reference line, reference wording, and the quest pin since the reviewed head).

• Reviewer: Codex, gpt-6.1-sol, medium effort (quest review --base origin/main, round 1)

• Reviewed head: e0a996f

• Findings: none

Update for moq-dev/quest#460

moq-dev/quest#460 made quest context the command agents run before any work, and quest guide quest-only (the context says when to run it). This push changes the AGENTS.md reference line to Quests: before any work, run `quest context` and follow it., repoints CONTRIBUTING.md references to the moved Reviews rules, and bumps quest to 4be350816f2a5c1157f799773ee1594f199fd9a7. The repository's checks pass on the new head.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

[coderabbitai]

Walkthrough

Contributor and prompting guidance now refers to quest context. AGENTS.md is shortened, and PROMPTING.md is removed. The quest flake input now points to revision 4be350816f2a5c1157f799773ee1594f199fd9a7.

Merge Risk: Minimal · up to cf073

No concrete merge-blocking defect is established. The documentation now delegates shared guidance to quest context, although its review and prompting instructions could not be independently confirmed.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title 'docs(agents): rely on quest context for shared rules' matches the main change. AGENTS.md drops shared rules and points agents to 'quest context', PROMPTING.md is removed, and the quest pin …
Description check		The description is closely related to the changeset. It explains that rust2 now relies on 'quest context' instead of copied rules, lists the AGENTS.md trimming, the PROMPTING.md removal, the .claude/r…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title 'docs(agents): rely on quest context for shared rules' matches the main change. AGENTS.md drops shared rules and points agents to 'quest context', PROMPTING.md is removed, and the quest pin is bumped. The title names the primary change and uses a conventional-commit scope, so it is specific and clear.

Full details: Description check

Explanation

The description is closely related to the changeset. It explains that rust2 now relies on 'quest context' instead of copied rules, lists the AGENTS.md trimming, the PROMPTING.md removal, the .claude/rules/prompting.md repoint, and the flake.nix quest pin bump. It also gives validation steps and a follow-up update section.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches

Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

[pullfrog]

✅ No new issues found.

Reviewed changes

Reviewed the diff against main:

• AGENTS.md: reduced to rust2-specific rules, the just commands, and an instruction to run quest context and quest guide before starting work.
• PROMPTING.md: deleted. Its content lives in the Prompting section of quest context at the pin.
• .claude/rules/prompting.md: repointed at quest context; no other tracked file referenced PROMPTING.md.
• flake.nix / flake.lock: quest pin dc8008bc → 9277dc34, with the lock regenerated to match.

The load-bearing claim was verified directly: quest context and quest guide print quest's assets/CONTEXT.md and assets/AGENTS.md, and at the new pin those cover every rule dropped from AGENTS.md (root-cause fixes, fail loud, nested AGENTS.md reads, CONTRIBUTING.md, the AI marker, em dashes, public-repo privacy, the Nix dev shell, benchmarks, public-API impact, foo_with_x shims, and the Prompting guidance that replaces PROMPTING.md). The regenerated lock matches quest's inputs at that rev: nixpkgs-opencode at f20cd90e and quest-pinned at 2aa60a2d. The handful of generic rules dropped without an exact upstream equivalent are disclosed in the PR body as candidates for quest's CONTEXT.md, and none are rust2-specific.

  ^{｜ View workflow run ｜ Using glm-5.3-flash ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes

Reviewed the delta against the prior pullfrog review at e0a996f (the cf0736bc commit):

• AGENTS.md: the quest reference line now says "before any work, run quest context and follow it", dropping the direct quest guide mention.
• CONTRIBUTING.md: the /quest-review rule locally now reads "as quest context describes" instead of "as the quest guide describes".
• flake.nix / flake.lock: quest pin bumped 9277dc34 → 4be35081, lock regenerated to match.

The new references were verified against the pinned source: quest's assets/CONTEXT.md at 4be35081 contains a Prompting section (what .claude/rules/prompting.md points at), a Reviews section that covers the local-review rule, the required ## Review record, the trivial-skip allowance, and "address findings already posted on the head", and a Quests section that tells agents when to run quest guide — so despite the dropped mentions nothing needs restating. The regenerated lock keeps the same sub-inputs (nixpkgs-opencode at f20cd90e, quest-pinned at 2aa60a2d) the first review validated.

  ^{｜ View workflow run ｜ Using glm-5.3-flash ｜ 𝕏}

[coderabbitai]

Additional comments: 2

CONTRIBUTING.md-35-35: 1

35-35: Minor · Potential issue · Low value

Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.

The new reference may not lead reviewers to /quest-review instructions if quest context does not describe that workflow as the former quest guide did.

The contributor lacks the referenced review procedure and may skip or incorrectly perform the required review.

This can occur when: A contributor consults quest context to perform the required local PR review.

.claude/rules/prompting.md-8-8: 1

8-8: Minor · Potential issue · Low value

Unverified finding
We couldn't verify this from the code. It is shown for review, not as a verified issue.

Replacing the root prompting document with quest context may leave this rule pointing to a Prompting section that omits instructions formerly required when editing AGENTS.md, CONTRIBUTING.md, or skills.

The agent can make an edit contrary to a prompting requirement that the former document supplied.

This can occur when: An agent edits one of the rule's matched files and follows only the referenced Prompting section.

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6876a270-3e06-4ec9-8f8c-525dd9a401ef

Commits

Reviewing files that changed from the base of the PR and between 1b0fe64 and cf0736b.

Files ignored due to path filters: 1

• flake.lock is excluded by !**/*.lock

Files selected for processing: 5

• .claude/rules/prompting.md
• AGENTS.md
• CONTRIBUTING.md
• PROMPTING.md
• flake.nix

Files with no reviewable changes: 1

• PROMPTING.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.