Repository navigation
refactor: outsource loading and validation - #27
Merged
Merged
Conversation
* port ifs-forecast loader * updated ifs forecast loader to also handle ensemble data (#19) --------- Co-authored-by: nielscarlier <136123206+nielscarlier@users.noreply.github.com> Co-authored-by: Stagiair user Niels Carlier <nicarlier@kili.oma.be>
Contributor
Author
|
This will temporarily break the example configs. But these will be fixed in the follow-up PR #30. |
3 tasks done
mpvginde
added a commit
that referenced
this pull request
Oct 28, 2026
#47) * Remove leftover loaders package and finish loader separation (for v0.2.0) PR #27 moved dataset loading and validation to mlwp-data-loaders but left a broken src/mxalign/loaders/ package behind. Remove it and finish the separation for the v0.2.0 release. - Delete src/mxalign/loaders/ and drop it from __all__ - Runner.load_datasets now calls mlwp_data_loaders.load_and_validate_dataset; grid_mapping is applied afterwards via ds.mx.add_grid_mapping - loader: in YAML configs is now a dotted module path or a .py file - Update README, example config and changelog (with migration note) Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes loading and validation of datasets from the mxalign package.
The validation of datasets is now outsourced to mlwp-data-specs
The loading of datasets is now outsourced to mlwp-data-loaders