Repository navigation
Conversation
The tests/ directory was empty after removing the properties test, so `pytest tests` failed with exit code 4 in CI. The new test also caught that `loaders` was still listed in mxalign.__all__ after its removal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Hadn't noticed that you already fixed this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
Run Unit Testscheck on #27.After the properties test was removed,
tests/no longer existed in the repo, sopytest testsexited with code 4 (file or directory not found).tests/test_import.py, which checks thatmxalignimports and that every name inmxalign.__all__exists."loaders"frommxalign.__all__. The loaders module was removed in refactor: outsource loading and validation #27, sofrom mxalign import *would raise an error. The new test caught this.🤖 Generated with Claude Code