Repository navigation
Finish loader separation: remove leftover loaders package (for v0.2.0) - #47
Merged
Merged
Conversation
…2.0) PR #27 moved dataset loading and validation to mlwp-data-loaders but left a broken src/mxalign/loaders/ package behind. Remove it and finish the separation for the v0.2.0 release. - Delete src/mxalign/loaders/ and drop it from __all__ - Runner.load_datasets now calls mlwp_data_loaders.load_and_validate_dataset; grid_mapping is applied afterwards via ds.mx.add_grid_mapping - loader: in YAML configs is now a dotted module path or a .py file - Update README, example config and changelog (with migration note) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…odespell args Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the mxalign v0.2.0 release (the separation release, see RELEASE_PLAN step 2).
PR #27 outsourced loading and validation to mlwp-data-loaders / mlwp-data-specs, but left a broken
src/mxalign/loaders/package onmain(it imports modules that no longer exist) and aRunnerthat still imported.loaders.loader.src/mxalign/loaders/and drop it from__all__Runner.load_datasetsnow usesmlwp_data_loaders.load_and_validate_dataset;grid_mappingis applied afterwards viads.mx.add_grid_mappingloader:in YAML configs is now a dotted module path (e.g.mlwp_data_loaders.loaders.anemoi.anemoi_inference) or a.pyfile; short names no longer workexamples/config.yamland CHANGELOG (with migration note)Not in this PR (still needed before tagging v0.2.0)
[tool.uv.sources]with released versions once mlwp-data-loaders v0.1.0 is out, then re-lock with uv 0.13.5Test plan
pytest(3 passed)mxalign.runnerimportsexamples/config.yaml(needs earthkit-data and the data)🤖 Generated with Claude Code