Repository navigation
Conversation
Default checkpoint and profile runs to cli. Require Connect callers to opt in explicitly, and preserve caller-provided sources in telemetry and compact results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 70ddf006-7f8d-48e7-9afa-3fbae73b3864
…heck-invocation-source
Honor FlightCheck invocation opt-out, keep telemetry imports fail-open, classify mapped exception bases, and enforce CLI coverage decisions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 70ddf006-7f8d-48e7-9afa-3fbae73b3864
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix FlightCheck invocation-source attribution and address the follow-up review on merged PR #486.
invocationSource=cli. Preserve explicitadk,installer, andconnectsources, and explicitly passconnectfrom the Connect lifecycle runner and ServiceNow controller.--no-telemetryflag for the entire SDK invocation, including authentication session starts, API events, and script crash diagnostics. Nested boundaries cannot re-enable it; suppression is checked before starting asynchronous transport threads and restored afterward. ServiceNow and maker-diagnostics child runs retain their explicit opt-out.__mro__, covering missing files, permissions, JSON decoding, subprocess failures, and requests HTTP errors. Payloads still contain only fixed messages/codes, never exception text or class names.flightcheck_setup.py, and require every__main__script to be registered or explicitly excluded. Removed scripts must also leave the registry/exclusion inventory.Telemetry impact
The invocation-source fix changes attribution only for future targeted runs without an explicit source. Historical
connectevents cannot be retroactively distinguished.The follow-ups reuse the existing script-error event and fields; subprocess errors gain a fixed
processcategory/code. No global exception hooks or arbitrary error text are introduced. Schema stays at main's 1.8.0; #436 owns its pending 1.9.0 bump and must retain the merged crash-diagnostic additions. #495 must remove its deleted CLI registrations/exclusion together with the scripts.Verification
Focused offline runs passed: 412 SDK tests, 265 FlightCheck CLI/checkpoint/profile/consent tests, and 672 Connect/lifecycle/maker-diagnostics tests. Coverage includes asynchronous opt-out, nested suppression, consent restoration, all 33 registered entry-point guards with failed telemetry imports, exception preservation, fixed-text MRO classification, and CLI coverage inventory.
The repository's pinned Ruff 0.16.0 pre-commit gate and
git diff --checkpassed. No live collector or customer backend was used. Remote CI is separate.