Repository navigation
agentconfig-mcp: add shared LPC operation telemetry - #436
Open
Asher Johnson Hogan (asherjh) wants to merge 8 commits into
Open
Asher Johnson Hogan (asherjh) wants to merge 8 commits into
Asher Johnson Hogan (asherjh) wants to merge 8 commits into
Conversation
Measure landing-page tool reliability and usage with one content-free completion record while keeping shared HTTP behavior and existing telemetry callers compatible. Make the core instrumentation opt-in so Org Announcements can integrate separately. - Add optional MCP and usage fields to the existing API-call event schema. - Observe all ten LPC tools with request-local identity, timing, and HTTP summaries. - Preserve the app-only schema-v2 client bridge and exclude it from business records. - Add native protocol, privacy, concurrency, retry, and compatibility regressions. - Document canonical cohorts, installation metrics, and delivery limitations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe7b727c-3609-48cc-8c27-becc4fd98998
Asher Johnson Hogan (asherjh)
requested review from
Caroline Creighton (ccreight),
Drew Owen (dcowen91),
rebova-microsoft and
srpingal
October 16, 2026 00:05
6 tasks done
Internal telemetry analysis belongs in private repositories. The existing public disclosure covers the collection categories used by this instrumentation. - Restore the existing README and telemetry investigation guide. - Restore the existing KQL queries. - Preserve the shared SDK/core/LPC instrumentation and tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe7b727c-3609-48cc-8c27-becc4fd98998
Keep shared LPC operation telemetry compatible with the current session lifecycle and Stay up to date configuration APIs. - Merge the latest main into the LPC telemetry branch. - Retain MCP instrumentation and current configuration guidance. - Validate API projection, ordered buffer replay, and asynchronous delivery with session-start events. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25307f66-8638-4a01-a8e7-24bf0a5d8f06
Link each widget invocation and every backend HTTP attempt without conflating retries or concurrent calls. Keep telemetry content-free while preserving existing transport behavior and schema-v2 bridge compatibility. - Accept validated root/request correlation metadata with independent server execution IDs. - Emit distinct HTTP attempt IDs and records across retries and 401 refresh replays. - Return LPC correlation metadata and project optional client bridge correlation IDs. - Cover native MCP, concurrency, error/cancellation, opt-out, and buffered redelivery. - Preserve legacy telemetry field shapes and branch-specific SDK behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe7b727c-3609-48cc-8c27-becc4fd98998
Drew Owen (dcowen91)
previously approved these changes
Nov 11, 2026
…herj/adk-core-lpc-observability # Conflicts: # solutions/ess-maker-skills/scripts/adk_telemetry.py # tests/test_adk_telemetry.py Co-authored-by: asherjh <100732777+asherjh@users.noreply.github.com>
Canonical lowercase identifiers keep request metadata and client telemetry joinable when callers supply uppercase UUIDs. - Normalize validated incoming MCP correlation and client request IDs. - Normalize the three optional client correlation fields while preserving malformed-field omission and legacy operation ID validation. - Cover uppercase metadata through native MCP execution and client telemetry ingestion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fe7b727c-3609-48cc-8c27-becc4fd98998
4 of 8 tasks
Contributor
|
Coordination from the follow-up review on merged #486: #494 (8021abe) retains main SCHEMA_VERSION=1.8.0 and adds no payload fields. Please keep this PR's 1.9.0 bump when reconciling main, together with the merged script-error constants/registry and the follow-up opt-out/MRO fixes. The new invocation-scoped suppression must be checked before spawning transport threads because ContextVar state does not flow to those threads. No LPC changes were copied into #494. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add shared LPC operation telemetry.
Measure landing-page tool reliability and usage with one content-free completion record while keeping shared HTTP behavior and existing telemetry callers compatible. The shared infrastructure is opt-in; this PR integrates LPC only, with Org Announcements reserved for a separate follow-up.
adk.api.callevent with optional schema-1.8 server and usage metadata. Existing callers omit the new fields and retain their outcome/error semantics.call_toolboundary, covering argument validation, handler execution, returned tool errors, output conversion, unknown tools, exceptions, and cancellation without changing results or propagation.All 14 implementation files are included: six SDK/core/LPC source files, five test files, and three documentation/query files. No Org Announcements source, Graph client, manifests, visual surfaces, or monitor configuration are changed. There are no additional event families, per-attempt streams, or distributed tracing framework.
Type of change
Testing
pre-commit rungate passed using its pinned Ruff 0.16.0 hook. Source/test lint, syntax compilation,git diff --check, and standalone SDK/core imports without MCP also passed.Combined test command, from the repository root:
No real backend or collector was used. KQL examples were reviewed locally, not executed against live production. Org integration is not exercised here. The remote CI matrix is pending and is not claimed to have passed; local Python differs from CI's Python 3.11 environment. Asynchronous completion records and accepted bridge batches do not guarantee collector delivery or establish process availability.
Checklist