Repository navigation
Conversation
Add bounded native list, read, create and update operations with selected Dev authentication, exact previews, explicit approval and authoritative readback. Keep new topics inactive and preserve existing topic identity and state. Route Maker topic actions through the supported fixed-answer path. Native create/update and readback have Dev-agent runtime evidence. Maker extension rail changes have unit coverage only; activation and publication are outside the save operation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Read current native GPT instructions and preview separately approved text replacements while preserving expression segments, unknown metadata and unrelated components. Reuse the selected Dev connection, existing transport and native change-token checks. Wire topic alignment guidance to the native baseline and separate instruction preview/save operations. Keep topic and instruction approvals and outcomes distinct; do not treat their saves as atomic or use stale extracted instructions. Validation: 161 focused Python cases and 59 Maker extension tests passed. Native CLI read/preview was exercised; the save path is unit-covered, and the newly wired Maker conversation path has not been replayed live. Instruction capability-usage telemetry is deferred; existing topic telemetry is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Select the existing connection helper and identity tests from ee1a62152b73d40854056e25bd13c3c6bc488f2f for the authoring layer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Replace fixed-response and instruction-edit request formats with ordinary Object Model YAML drafts. Preserve scoped concurrency, captured-draft bookkeeping, and verified remote outcomes for secondary local failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Route topic authoring through the normal create and update skills, retire the separate crafted-response and eval-scenario lifecycles, and make unsupported workflow routes notice-only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep scoped topic reconciliation, explicit activation, and native evaluation deployment. Share local comparison, captured-content persistence, and read-only flow diagnostics. Preserve instruction-only concurrency checks and known remote results across later local failures. BREAKING CHANGE: push.py no longer deploys Dataverse components. No-scope invocation only inspects local changes; writes require an explicitly scoped native topic or evaluation operation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reconcile the shared SDK and YAML adapters, preserve scoped acknowledgement and existing Workday/evaluation consumers, and align routing, publication advisories and Maker Profile guidance with the supported native operations. Keep conversation acceptance pending in the basic layer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Connect Maker /test to native topic inspection and attach-only embedded chat driving. Preserve current-turn evidence, exact-response checks, native integrity, and same-attempt observation without replay. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Scope integrity checks to the selected topic, retain text-empty cards upstream, treat classifier and screenshot hints as diagnostics, and preserve known capture/readback facts across local output failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Replace contradictory topic-test guidance with the bounded native procedure. Remove dedicated legacy adapters and tests while retaining local debug transforms, shared drive contracts, read-only flow inspection and publication coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Reject ambiguous action identities and diagnostic ID collisions. Require exact owned-node content for guarded cleanup while preserving unrelated topic edits. Cover placement, identity conflicts and cleanup ownership with focused tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Reject ambiguous action identities and diagnostic ID collisions. Require exact owned-node content for guarded cleanup while preserving unrelated topic edits. Cover placement, identity conflicts and cleanup ownership with focused tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Support explicit activation, browser preparation, general turn capture and independent observation. Align authoring and Push consent with shared goal-focused outcomes while preserving test-only intent and uncertain Sends. Document owned temporary-value observation and cleanup composition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Share topic summaries, component inventory, scoped consent and debugging outcomes across topic and evaluation authoring. Keep previews in normal chat and preserve capability-aware testing offers, readiness and pause handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Guide session-led diagnosis, safe value observation and post-save test preparation while retaining browser state and scoped authoring ownership. Expose advisory capture signals and an opt-in empty-boundary guard, with regression coverage and read-only browser detection guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bef4d3bc-5d8a-4a5d-9125-11e4a6596665
Acknowledge authoritative topic readback after reconciled saves, preserve later local drafts, and retain known remote results when local bookkeeping fails. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Acknowledge authoritative topic readback after reconciled saves, preserve later local drafts, and retain known remote results when local bookkeeping fails. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Carry declined instruction corrections as testing exclusions, link available native result evidence even without screenshots, and restore test-page controls after viewport overrides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Review routing corrections before Push with exact component scope, preserve declined corrections, and report verified component outcomes. Keep metadata classification, named exclusions and conflict recovery summaries consistent without enabling native testing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Review routing corrections before Push with exact component scope, preserve declined corrections, and report verified component outcomes. Keep metadata classification, named exclusions and conflict recovery summaries consistent while retaining scoped native testing handoffs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Preserve topic authoring and scoped saves alongside current setup, Connect, FlightCheck, and telemetry fixes. Accept removal of the retired Workday setup topic route and align its source-contract guard. Validation retains confirmed pre-existing branch/upstream failures; telemetry feature work remains separate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Integrate upstream main through Basic while preserving the bounded testing, debugging, evidence, and activation safeguards. Retain the current upstream telemetry SDK and FlightCheck fixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Count authoring at drafting and testing per attempted pass, rather than individual helper calls. Expose bounded lifecycle emission and retain approved batch, cancellation, no-write and environment-SKU policies in session guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Preserve supplied response wording and links, distinguish suggested wording, and support revision before scoped Push approval. Make local workspace draft persistence explicit while retaining separate instruction consent, save safeguards and wording-preserving debugging. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Preserve the pinned shared catalog and schema unchanged, and supplement the Core, HR, and IT template inventories with source-revision coverage. Catalog coverage does not establish customer ownership or applicability to every installed revision. Live Maker verification remains pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Centralize catalog-backed ownership guidance across authoring, Push, cleanup, and debugging. Require independent customer-origin evidence before mutation. Reject same-name creates before preview or save writes, including collisions appearing after preview. Add focused coverage for catalog integrity, shared guidance, and no-write duplicate rejection. Live Maker verification remains pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Preview the selected topic subtree, reject changed scope, and verify remote absence before reconciling local files. Preserve uncertain writes and newer workspace edits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Click the selected Test pane New chat control once and detach. Keep timing, recovery, capture and interpretation in the session. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Centralize shared policy and literal template rendering, then load focused authoring, deletion, Push and testing references on demand. Route supported deletion and reset operations through their owners and preserve scoped consent and truthful outcomes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Replace ambiguous native wording in changed instructions, docs and user-facing diagnostics. Preserve stable identifiers and update dependent guidance assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
added 6 commits
November 13, 2026 11:51
Preserve template deletion protection without requiring customer-origin evidence for ordinary authoring. Keep entry points and regression guards aligned with the shared policy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Keep literal response wording, review headings, native decision controls and progress guidance consistent across topic authoring and testing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Define outcome-neutral reporting markers with local completion conditions. Emit standalone updates before review and after approved saves without conflating draft, no-write, failed or partial outcomes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Extend owner-scoped status markers, uppercase H5/H6 templates and explained decisions across authoring, Push, deletion, testing and cleanup. Preserve local-only intent and excluded pending changes. Validation: 49 guidance checks pass; the synthetic happy-path round completed. Final heading templates have source checks but no fresh Maker visual pass. Cleanup did not reproduce a real editor diagnostic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Rename the driver and facade reset method to newChat. Prefer the direct button, fall back through navigation before an actual click, and preserve fresh-state guidance and causal evidence without replaying an uncertain click. Validation: 194 focused checks and lint pass. Direct-button and navigation-fallback paths both passed on the owned live Test pane. Maker discovery from canonical guidance, server-side conversation identity and saved-version execution remain unproven. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Accept HTTP-successful topic deletion without a post-write inventory readback. Add scoped routing-conflict resolution, instruction previews, and joint or instruction-only Push choices with explicit consent and outcome boundaries. Validation: 97 focused tests, Ruff, Prettier, Markdownlint, and whitespace checks passed. Live journeys covered joint and scoped saves, local staging, cancellations, and instruction draft retention. Six remaining decision branches were blocked when the test environment was cleaned up. Observed exclusion-reporting gaps remain outside this change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Retain named exclusions through routing handoffs, subset review and cancellation. Preserve New Chat action outcomes independently of cleanup failures and reuse the validated initial component inventory. Correct deletion documentation, inspection ownership and stale guidance assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
Keep retired topic/debug adapters deleted and remove their crash-telemetry registrations. Combine Push structured error evidence and UTF-8 output with the upstream script-error boundary and failure exit handling. Add regression coverage for preserved handled-error evidence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45972120-90da-4a86-b7bb-6c8ce20c4261
nkemms
marked this pull request as ready for review
November 16, 2026 16:42
This was referenced Nov 16, 2026
Contributor
|
Coordination from the follow-up review on merged #486: #494 (8021abe) adds a test requiring every main script to be registered for crash diagnostics or explicitly excluded, with no stale entries. When rebasing this PR, please remove drive_topic, eval_scenario, plant_debug, and strip_debug from SCRIPT_ERROR_ENTRY_POINTS together with their deleted files. Also remove topic_checker_capture from the explicit exclusion set in test_every_cli_has_a_script_error_coverage_decision. Register or explicitly exclude any newly introduced CLI guards. Those scripts remain instrumented in #494 until their deletion lands here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a unified topic-authoring and testing experience for the Employee Self-Service Agent Developer Kit. Makers can create, update, review, save, delete and test topics through scoped operations, with clear approvals and results that distinguish local drafts, saved changes and observed runtime behavior.
Description
The Maker Kit shares the selected Development agent connection across setup and authoring, supports topic and instruction changes with conflict detection, and coordinates Push and deletion with template protection and local reconciliation. Topic workflows use consistent status updates, uppercase review and outcome headings, explained choices and separate decision controls while preserving approved response wording and unrelated changes. Conversation testing supports explicit activation, browser observation and diagnostics; starting a new chat now tries the direct button before opening navigation, and reports uncertain clicks without repeating them. This replaces the retired Dataverse-backed Push and legacy testing adapters; saving, activation, testing and publication remain separate operations.
Outcome
Needs human review. The changes are committed and the exercised happy paths completed successfully, including both ways of starting a new chat. Review the authoring, approval and testing behavior together; the PR remains a draft.
Testing
Live testing covered topic creation and saving, activation, conversation testing, update and retest, local drafts, Push, cleanup and deletion