You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For example, mCurrent is set two lines below. If you really need to fix this, which I think you should not, please do the correct cleanup, not merely the one which silences an innocuous warning by doing unnecessary zeroing.
For example, mCurrent is set two lines below. If you really need to fix this, which I think you should not, please do the correct cleanup, not merely the one which silences an innocuous warning by doing unnecessary zeroing.
I think you are referring to the explicit constructor ColumnIterator(arrow::ChunkedArray const* column) which initialises the members to 0/nullptr in the initialiser list and does not need fixing.
This PR is fixing the default constructor ColumnIterator() = default which leaves the members in undefined states which then manifests here.
The fix is replacing the initialiser list in the explicit constructor with default member initialisers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise left uninitialised by the default constructor.