Skip to content

DPL Analysis: Initialise ColumnIterator members - #15877

Closed
vkucera wants to merge 1 commit into
AliceO2Group:devfrom
vkucera:column-constructor
Closed

vkucera wants to merge 1 commit into
AliceO2Group:devfrom
vkucera:column-constructor

Conversation

@vkucera

@vkucera vkucera commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Otherwise left uninitialised by the default constructor.

@vkucera
vkucera marked this pull request as ready for review September 30, 2026 19:42
@vkucera
vkucera requested a review from a team as a code owner September 30, 2026 19:42
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 4858cef at 2026-09-30 23:36:

No log files found

Full log here.

@ktf ktf closed this Sep 30, 2026
@ktf

ktf commented Sep 30, 2026

Copy link
Copy Markdown
Member

they get inititialized at a later point.

@vkucera

vkucera commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

they get inititialized at a later point.

Where?

@ktf

ktf commented Oct 1, 2026

Copy link
Copy Markdown
Member

For example, mCurrent is set two lines below. If you really need to fix this, which I think you should not, please do the correct cleanup, not merely the one which silences an innocuous warning by doing unnecessary zeroing.

@vkucera

vkucera commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

For example, mCurrent is set two lines below. If you really need to fix this, which I think you should not, please do the correct cleanup, not merely the one which silences an innocuous warning by doing unnecessary zeroing.

I think you are referring to the explicit constructor ColumnIterator(arrow::ChunkedArray const* column) which initialises the members to 0/nullptr in the initialiser list and does not need fixing.
This PR is fixing the default constructor ColumnIterator() = default which leaves the members in undefined states which then manifests here.

if (O2_BUILTIN_UNLIKELY(((mCurrent + ((*mCurrentPos + *mGlobalOffset) >> SCALE_FACTOR)) >= mLast))) {

The fix is replacing the initialiser list in the explicit constructor with default member initialisers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants