Skip to content

DPL Analysis: Fix DECLARE_SOA_CCDB_COLUMN_FULL's default construcor w… - #15679

Closed
mhemmer-cern wants to merge 1 commit into
AliceO2Group:devfrom
mhemmer-cern:fix-ccdb-column
Closed

mhemmer-cern wants to merge 1 commit into
AliceO2Group:devfrom
mhemmer-cern:fix-ccdb-column

Conversation

@mhemmer-cern

@mhemmer-cern mhemmer-cern commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

…hich was firing cppcoreguidelines-pro-type-member-init in O2Physics code when used.
The concrete error was: Constructor does not initialize these bases: Column

…hich was firing `cppcoreguidelines-pro-type-member-init` in O2Physics code when used
@mhemmer-cern
mhemmer-cern requested a review from a team as a code owner August 14, 2026 08:54
@mhemmer-cern

Copy link
Copy Markdown
Contributor Author

This got triggered when the clang-tidy settings in O2Physics got changed: AliceO2Group/O2Physics#16868

@mhemmer-cern

Copy link
Copy Markdown
Contributor Author

Hello @ktf @aalkin ,
Could you have a look at this please?

@ktf

ktf commented Aug 15, 2026

Copy link
Copy Markdown
Member

Isn't this an issue with the linter?

@mhemmer-cern

Copy link
Copy Markdown
Contributor Author

I mean yeah sure it was clang-tidy that stated the issue. From my understanding this way Column is not left not initialize. I don't know if the default constructor is an actual problem that needs fixing, but if it silents the linter, shouldn't it be fine?

@alibuild

alibuild commented Aug 23, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for fa1c4f9 at 2026-08-23 06:25:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@github-actions

Copy link
Copy Markdown
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions Bot added the stale label Sep 23, 2026
@github-actions github-actions Bot closed this Sep 28, 2026
@vkucera

vkucera commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

@ktf @mhemmer-cern Clang-Tidy is right on this one, although the root cause is deeper, namely the default ColumnIterator constructor leaving its members uninitialised. Fixed in #15877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants