Skip to content

DPL Analysis: Initialise ColumnIterator members #15877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkucera wants to merge 1 commit into from
Closed

DPL Analysis: Initialise ColumnIterator members #15877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions Framework/Core/include/Framework/ASoA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,13 +506,7 @@ class ColumnIterator : ChunkingPolicy
/// it. This means that a ColumnIterator is actually only available
/// as part of a RowView.
ColumnIterator(arrow::ChunkedArray const* column)
: mColumn{column},
mCurrent{nullptr},
mCurrentPos{nullptr},
mGlobalOffset{nullptr},
mLast{nullptr},
mFirstIndex{0},
mCurrentChunk{0}
: mColumn{column}
{
auto array = getCurrentArray();
mCurrent = reinterpret_cast<unwrap_t<T> const*>(array->values()->data());
Expand Down Expand Up @@ -609,13 +603,13 @@ class ColumnIterator : ChunkingPolicy
return *this;
}

mutable unwrap_t<T> const* mCurrent;
int64_t const* mCurrentPos;
uint64_t const* mGlobalOffset;
mutable unwrap_t<T> const* mLast;
arrow::ChunkedArray const* mColumn;
mutable int mFirstIndex;
mutable int mCurrentChunk;
mutable unwrap_t<T> const* mCurrent{nullptr};
int64_t const* mCurrentPos{nullptr};
uint64_t const* mGlobalOffset{nullptr};
mutable unwrap_t<T> const* mLast{nullptr};
arrow::ChunkedArray const* mColumn{nullptr};
mutable int mFirstIndex{0};
mutable int mCurrentChunk{0};

private:
void checkSkipChunk() const
Expand Down
Loading