Skip to content

Fix the weather reload loop with Google icons - #5258

Open
Entrpi wants to merge 1 commit into
valinet:masterfrom
Entrpi:fix/weather-google-icon-reload
Open

Entrpi wants to merge 1 commit into
valinet:masterfrom
Entrpi:fix/weather-google-icon-reload

Conversation

@Entrpi

@Entrpi Entrpi commented Nov 18, 2026

Copy link
Copy Markdown

Problem

On ExplorerPatcher 26100.9711.71.1, selecting the Google icon pack can make the weather flyout briefly show the forecast, then return to “Unable to load weather information.” Clicking Reload repeats the failure.

The shared forecast parser calls ep_weather_icon(), but only the Microsoft icon pack initializes that helper. The Google path throws ReferenceError: ep_weather_icon is not defined. This follows the parser changes in #5198.

Change

Define the icon lookup helper once and include it in both icon packs’ initialization scripts.

Verification

  • Reproduced the failure with the original DLL on Windows 11 25H2 x64.
  • Rebuilt the weather host and verified that both icon packs parsed a live forecast, including the icon image.
  • Installed the patched DLL and confirmed that the taskbar flyout stayed on the forecast with Google icons selected.

@pyrates999

Copy link
Copy Markdown

was this generated using AI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants