Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Google Search now supplies SVGs for conditions such as cloudy, partly sunny, and light rain. The Microsoft pack's existing PNG matcher leaves these SVGs displaying Google artwork.
Change
Review order
The first commit is the shared icon lookup fix from #5258. A local merge preview with #5259 found one conflict in
ep_weather_host.c, where both changes select and load icon packs. The local resolution built successfully and passed live switching tests across Google, Microsoft, and ExplorerPatcher, plus a browser test that switched packs during a pending Microsoft image decode.Verification