Repository navigation
feat(screenshots): import into the App Asset Library (--to-library) - #37
Merged
Merged
Conversation
`asc screenshots import --to-library` uploads each distinct file once to the app's asset library, waits for processing, places each image in the version-localization slot that matches its exact pixel size, and orders each group to match the manifest. `--existing fail|replace|append` decides what happens to a group that already has placements; `--placement-group` settles the few sizes that fit two groups (iPad 12.9"/13", Apple TV/Vision Pro); `--dry-run` prints the plan. One result per locale and group, with status and next commands. Also on REST: POST /api/v1/versions/:versionId/screenshots/import?to-library=true. Affordance gains `flags` for bare CLI flags; the four-argument initializer is kept for installed plugins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The screenshot-import REST path is wired into normal initialization. Although its registration also depends on video-repository setup, the available evidence does not establish a concrete failure condition that would make the endpoint unavailable; no merge-blocking risk is identified. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 26.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 21 files. (1 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly and concisely identifies the primary change: adding an opt-in --to-librarypath for screenshot imports.Description check The description includes all required sections, explains the motivation and implementation, documents verification, and completes the repository checklist. The issue link remains unspecified in `Fixes… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 26.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 46 functions across 21 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
5 tasks done
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 84.43% 84.29% -0.15%
==========================================
Files 519 524 +5
Lines 15600 15879 +279
==========================================
+ Hits 13172 13385 +213
- Misses 2428 2494 +66
🚀 New features to boost your workflow:
|
…rt-to-library # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Apple deprecated app screenshot sets in API 4.5.1.
asc screenshots import, used by the screenshot editor andapp-shotsexport, still uploads into them. This adds the App Asset Library path, opt-in for now.What changed
asc screenshots import --version-id V --from export.zip --to-library [--existing fail|replace|append] [--placement-group G]... [--dry-run]failby default. The group is reported asconflictwith areplacesuggestion, and other groups continue.replacedeletes the old placements first;appendkeeps them.status(planned/placed/conflict/ambiguous/noMatchingGroup/overLimit/failed) and next commands. The exit code is non-zero if any group isn't placed.POST /api/v1/versions/:versionId/screenshots/import?to-library=true, with the zip as the body.--to-library: unchanged, plus a deprecation note on stderr.--existing,--placement-groupand--dry-runare refused without--to-library, so a typo can't run a real import into sets.Shared change:
Affordancegainsflagsfor bare CLI flags (--to-library). The four-argument initializer is kept so installed plugins still link. Because the struct's layout changed, rebuild the ASC Pro plugin after this merges.How it was verified
swift testpasses: 651 + 1418 + 753.--dry-run(read-only) on a version in Prepare for Submission, using a synthetic two-locale zip:IPHONE_DYNAMIC_ISLAND_LARGE_PROFILE,planned.ambiguous(IPAD_13_PROFILE,IPAD_129_PROFILE), exit code 1.--placement-group IPAD_13_PROFILE→ bothplanned, exit code 0.Checklist
swift testpassesasc web-server## [Unreleased]inCHANGELOG.mdmake docs && make check-docspasses.p8, issuer ID or Apple ID session in the diff, output or screenshots🤖 Generated with Claude Code
Summary by CodeRabbit
--dry-run, or choose how to handle existing screenshots: fail, replace, or append.--to-librarycontinue using screenshot sets; this workflow is deprecated.