Repository navigation
fix(build): compile with Swift 6.2 (CI/release toolchain) - #38
Merged
Merged
Conversation
CI and release builds use Swift 6.2.4, which can't infer `.init(rawValue:)`
inside `value.flatMap { .init(…) }.map { [$0] }` (Swift 6.4 can), so main
has failed to build on CI since #32. Route the eight filter parameters
through a generic `sdkFilter(_:)` whose SDK type comes from the parameter.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The filter requests retain their prior behavior, and no user-facing regression is established. The change presents minimal merge risk. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: restoring compatibility with the Swift 6.2 CI and release toolchain. Description check The description includes all required sections, explains the Swift 6.2.4 build failure, summarizes the fix, documents verification, and completes the checklist. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 82.04% 82.36% +0.31%
==========================================
Files 492 518 +26
Lines 14362 15649 +1287
==========================================
+ Hits 11784 12889 +1105
- Misses 2578 2760 +182
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainhas failed Build & Test on CI since #32, so every open PR (#33–#37) fails too. CI and the release workflow build with Swift 6.2.4. Swift 6.2 can't infer.init(rawValue:)insidevalue.flatMap { .init(…) }.map { [$0] }; Swift 6.4, used locally, can. A release cut frommainwould fail the same way.What changed
The eight filter parameters in the asset-library image, video and placement adapters now go through a generic
sdkFilter(_:). Its SDK type comes from the parameter being filled. Behaviour is unchanged.How it was verified
mainCI run on Swift 6.2.4 failed withmember 'init(rawValue:)' … produces result of type …, but context expects …?.swift testpasses, including the tests that pin each filter's exact query string.Checklist
swift testpasses (the failing build on CI's toolchain)asc web-server(n/a)## [Unreleased]inCHANGELOG.md(n/a: fixes an unreleased build break)make docs && make check-docspasses.p8, issuer ID or Apple ID session in the diff, output or screenshots🤖 Generated with Claude Code
Summary by CodeRabbit