Repository navigation
fix(asset-library): show ACTIVE placements; document blocked-players 404 - #33
Merged
Merged
Conversation
Live App Store Connect returns placement state ACTIVE, which neither its OpenAPI spec nor its docs list. asc dropped those placements as unknown, so `asset-placements list` came back empty for images that are placed. Treat ACTIVE as neither editable, in review nor live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…point Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The change adds support for ACTIVE placements and documents the reported Game Center response. Apple’s acceptance of manually invoked ACTIVE operations remains unknown, but no concrete merge-blocking impact is established. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes both primary changes: handling ACTIVE asset placements and documenting the blocked-players 404 response. |
| Description check | |
The description includes the required Why, What changed, How it was verified, and Checklist sections. It documents the two changes and verification results clearly. The issue link remains unspecified,… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
-
📝 Generate docstrings
-
-
-
- Commit to this branch
- Create a new PR
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
CI and release builds use Swift 6.2.4, which can't infer `.init(rawValue:)`
inside `value.flatMap { .init(…) }.map { [$0] }` (Swift 6.4 can), so main
has failed to build on CI since #32. Route the eight filter parameters
through a generic `sdkFilter(_:)` whose SDK type comes from the parameter.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 82.04% 82.54% +0.49%
==========================================
Files 492 518 +26
Lines 14362 15649 +1287
==========================================
+ Hits 11784 12918 +1134
- Misses 2578 2731 +153
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Read-only checks against a live App Store Connect account after #32 found two problems.
What changed
ACTIVEwere dropped. App Store Connect sendsACTIVE, but neither its OpenAPI spec nor its docs list it.asc asset-placements listcame back empty for images that are placed.ACTIVEis now a known state, treated as neither editable, in review nor live, so asc doesn't offerdeleteorreorderGroupfor it.blocked-players listgets404 PATH_ERROR. The endpoint is in Apple's 4.5 spec and in the Game Center detail's ownblockedPlayerslink, but Apple doesn't serve it, with or without query parameters. Our request is correct, so this is documented as a Gotcha.How it was verified
.activeand an infrastructure test with the live response shape (red:type 'PlacementState' has no member 'active'). The state-names test now includesACTIVE, because the spec it was written from is incomplete.swift testpasses.asset-placements list --image-idnow returns the placement (ACTIVE, version localization).asset-library get,asset-placement-groups list(50 groups includingIPHONE_DUO_PROFILE) andasset-images list(73 images) decode correctly.Checklist
swift testpassesasc web-server## [Unreleased]inCHANGELOG.md(n/a: fixes an unreleased feature; documented in the feature Gotchas)make docs && make check-docspasses.p8, issuer ID or Apple ID session in the diff, output or screenshots🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation