fix: resolve operator version and Konflux selection at read time

[porridge]

Why

OperatorConfig.Configure used to bake resolved values into the persisted config:

• it set operator.version = roxie.version unconditionally, so an explicit operator.version was ignored. In CI for test: Migrate race-condition tests to roxie stackrox#23397 this made the operator bundle incorrectly resolve to -rcd tag (which does not exist for that image)
• it baked roxie.konfluxImages into operator.konfluxImages.

Because the post-Configure config is persisted into the cluster manifest and reused as the base on later runs, the baked values won on redeploy — a subsequent --tag / --konflux on the same cluster became a no-op.

What

• Resolve the operator version lazily in CentralVersion/SecuredClusterVersion: component.operator.version → operator.version → roxie.version.
• Resolve Konflux selection the same way in resolveKonfluxImages.
• With nothing left to bake, remove OperatorConfig.Configure and its call site.

Nothing version/Konflux-related is persisted anymore, an explicit operator.version wins, and --tag/--konflux always take effect on redeploy.

Regression tests added that fail at tip of main and pass here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: stackrox/roxie/.coderabbit.yml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 505d34a5-7e53-41d0-b945-b349be9fe5ec

📥 Commits

Reviewing files that changed from the base of the PR and between 1773975 and 3341562.

📒 Files selected for processing: 4

• cmd/deploy.go
• internal/deployer/config.go
• internal/deployer/operator_instances.go
• internal/deployer/operator_instances_test.go

💤 Files with no reviewable changes: 2

• cmd/deploy.go
• internal/deployer/config.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Operator version and Konflux image resolution now falls back to Roxie configuration after checking component-specific and shared operator settings. The deployment command no longer calls Operator.Configure, and that configuration method was removed.

Changes: Operator configuration fallback

Layer / File(s)	Summary
Resolve operator settings from configuration internal/deployer/operator_instances.go, internal/deployer/operator_instances_test.go, cmd/deploy.go, internal/deployer/config.go	Central and SecuredCluster versions and Konflux images now fall back to Roxie settings after component-specific and shared operator settings. Tests cover fallback behavior and operator-version precedence. The configure-time call and method were removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: vladbologa, mclasmeier

Merge Risk: ⚪ Minimal · up to 33415

Operator versions and Konflux images now resolve from component, shared operator, then Roxie settings. The removed configuration-time copy does not disrupt tag validation, and no concrete merge-blocking risk is established.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the main change: resolving operator version and Konflux selection at read time.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}