Skip to content

Fix --watch crash on new fsnotify events #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srid merged 2 commits into from
Sep 28, 2026
+6 −10
Merged

Fix --watch crash on new fsnotify events #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ebdea0
Fix --watch crash on new fsnotify event constructors (#679)
srid Sep 28, 2026
6715c98
Add changelog entry and bump to 1.9.38.0
srid Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Add Apple Silicon (aarch64-darwin) support (#677)
- Upgrade to GHC 9.10 (#677)
- Fix `gen --watch` crashing with "Non-exhaustive patterns" on file save (#679)
- Web interface
- Introducing *impulse* -- foundation for upcoming advanced search, replacing both z-index and legacy JS search (#108)
- Remove autoscroll behaviour (which had questionable value to begin with)
Expand Down
2 changes: 1 addition & 1 deletion neuron.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cabal-version: 2.4
name: neuron
version: 1.9.37.0
version: 1.9.38.0
license: AGPL-3.0-only
copyright: 2020 Sridhar Ratnakumar
maintainer: srid@srid.ca
Expand Down
13 changes: 4 additions & 9 deletions src/Neuron/Reactor.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,10 @@ watchDirWithDebounce ms dirPath' = do
nubByKeepLast f =
reverse . nubBy f . reverse
mkEventPathRelative :: FilePath -> FSN.Event -> Maybe FSN.Event
mkEventPathRelative baseDir = \case
FSN.Added fp t d ->
mkR fp <&> \p -> FSN.Added p t d
FSN.Modified fp t d ->
mkR fp <&> \p -> FSN.Modified p t d
FSN.Removed fp t d ->
mkR fp <&> \p -> FSN.Removed p t d
FSN.Unknown fp t d e ->
mkR fp <&> \p -> FSN.Unknown p t d e
mkEventPathRelative baseDir fse =
-- Use record update (rather than matching on each constructor), so that
-- new constructors in fsnotify (eg: CloseWrite) are handled. See #679.
mkR (FSN.eventPath fse) <&> \p -> fse {FSN.eventPath = p}
where
mkR fp = do
let rel = makeRelative baseDir fp
Expand Down
Loading