Repository navigation
Fix --watch crash on new fsnotify events - #680
Merged
Merged
Conversation
fsnotify 0.4 added CloseWrite, ModifiedAttributes and WatchedDirectoryRemoved, which mkEventPathRelative did not match, crashing on the first file save. Use a record update on eventPath so all constructors are handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679.
The GHC 9.10 upgrade (#677) pulled in fsnotify 0.4.4.0, which added new event constructors (
CloseWrite,ModifiedAttributes,WatchedDirectoryRemoved).mkEventPathRelativeinNeuron.Reactoronly matched the four older ones, soneuron gen --watchcrashed withNon-exhaustive patterns in \caseon the first file save (Linux emitsCloseWrite).The fix rewrites the path using a record update on
eventPath, which covers every constructor, including any future ones.Tested: reproduced the crash with the pre-fix build, then with this build ran
gen --watchand edited a note, added a PNG in a subfolder, created a note and deleted it. Each change rebuilt correctly with no crash.