Skip to content

test(evals): cover pinned root Skill reference reads - #232

Merged
harlan-zw merged 1 commit into
mainfrom
test/nikita-reference-workflow
Oct 8, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
test/nikita-reference-workflow

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

The existing CLI evals do not require an Agent to read a root Skill's supporting file.
Add a Nikita source lookup that checks the reference answer, the loaded commit, and absence of installation.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Approve automated work for the current issue state or pull request head commit. label Oct 8, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Approve automated work for the current issue state or pull request head commit. labels Oct 8, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent verification of head 6731684.

The real production case ran once per arm on opencode 1.18.32 and GLM 5.3 Flash. With the skilld Skill: 1.00. Without: 0.50. The with arm read onboarding.md at the loaded commit and installed nothing. No grader was skipped.

The same-commit grader accepted the recorded trace and rejected a changed reference commit.

Released skilld 3.6.0 installed the Nikita Artifact into an isolated opencode copy target. Lockfile restore recovered every source and target byte exactly. An older hosted Artifact reported pinned. A scratch lockfile fixture changed only its source selector to track the Repository, simulating a pre-push install. Update then advanced from 7e7f68d to f8b8a18 and refreshed the reference in both copies. Source verification passed after install, restore, and update.

The production refresh audit found a progressing hourly batch with no failures. Three refreshed nested references returned matching commit provenance and sizes. An unpinned reference returned the expected temporary 503. The audit did not claim all legacy snapshots had refreshed.

@harlan-github-agent harlan-github-agent Bot added the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 8, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-08 11:50 UTC.

GitHub merged this pull request.

  • Logged (30/100): A scored grader (weight 2 of 14) can false-fail correct runs because its evidence only survives an incidental 2000-character output truncation in the trace, making a healthy case look like a Skill regression. View code
    • Ask an agent to verify and fix this finding
  • Logged (25/100): The case's reference answer is pinned to a live third-party file that can change at any time, so the eval can rot silently and report a skilld Skill regression that is really upstream content drift. View code
    • Ask an agent to verify and fix this finding
  • Logged (10/100): The README score table was not updated with the new case's recorded results, leaving the eval documentation inconsistent with the run the pull request reports. View code
    • Ask an agent to verify and fix this finding

98680614-6f85-4137-824f-61bb51447e26

Selected findings run after merge and open separate pull requests.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 8, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit 56abeb4 into main Oct 8, 2026
4 checks passed
@harlan-zw
harlan-zw deleted the test/nikita-reference-workflow branch October 8, 2026 11:48
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant