Skip to content

test(evals): pin the Nikita source reference workflow - #233

Merged
harlan-zw merged 1 commit into
mainfrom
test/pin-nikita-reference-eval
Oct 8, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
test/pin-nikita-reference-eval

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Follow-up to #232.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Upstream edits and truncated tool output can fail the Nikita reference eval despite a correct lookup. Pin the Skill and reference graders to one immutable commit, and grade commands directly instead of truncated output. Regression cases reject mismatched commits and accept long tool output.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Approve automated work for the current issue state or pull request head commit. label Oct 8, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent verification: a live GLM 5.3 Flash/opencode run scored 1.00 with the Skill and 0.58 without it. The successful commands loaded the pinned root Skill and read onboarding.md at the same f8b8a1828cd53e4aedaa39c3e2abb01e71660bc0 commit. Both returned wroteSkillFiles: false. The run also recorded an initial direct-delivery failure in released CLI 3.6.0 before the hosted read succeeded.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Approve automated work for the current issue state or pull request head commit. labels Oct 8, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-08 13:21 UTC.

GitHub merged this pull request.

  • Logged (20/100): The new happy-path test cannot detect a grader that silently stops being scored, so a future regex typo in a grader file would weaken the eval while tests pass. View code
    • Ask an agent to verify and fix this finding

f3feb490-61e6-4fce-bf29-287acb17aaed

Selected findings run after merge and open separate pull requests.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 8, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit edf1e96 into main Oct 8, 2026
4 checks passed
@harlan-zw
harlan-zw deleted the test/pin-nikita-reference-eval branch October 8, 2026 13:19
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant