json: reject non-shareable default sort_keys proc from non-main Ractors - #1079
Open
eightbitraptor wants to merge 1 commit into
Open
eightbitraptor wants to merge 1 commit into
eightbitraptor wants to merge 1 commit into
Conversation
JSON::State.default_sort_keys_proc is registered at extension load time so it's owned by the main Ractor. When we implement the registration table on each Ractor storing another Ractor's unshareable Proc into that slot leaves a dangling reference when the owning Ractor runs a local GC. This commit ensures that we won't use a shareable proc by raising a Ractor::IsolationError.
Member
|
If we want to harden it, we can raise if we're not on the main Ractor, regardless of the proc. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in JSON now that addresses registered with
gc_register_addressare stored in per-Ractor tables rather than globally.It was originally fixed in
ruby/rubyas part of ruby/ruby#18393 - I am submitting this PR so that we can have the canonical commit here, and then the Gem sync task in Ruby will be a no-op.Summary
JSON::State.default_sort_keys_proc is registered at extension load time so it's owned by the main Ractor.
When we implement the registration table on each Ractor storing another Ractor's unshareable Proc into that slot leaves a dangling reference when the owning Ractor runs a local GC.
This commit ensures that we won't use a shareable proc by raising a Ractor::IsolationError.