Ensure default_sort_keys_proc isn't reassigned. - #1080
Merged
Merged
Conversation
eightbitraptor
left a comment
eightbitraptor
left a comment
Member
There was a problem hiding this comment.
Thanks @byroot - This looks like a much simpler approach.
| rb_raise(rb_eTypeError, "sort_key_proc must be a Proc"); | ||
| } | ||
| if (default_sort_keys_proc) { | ||
| rb_raise(rb_eArgError, "sort_key_proc can't only be set once"); |
Member
There was a problem hiding this comment.
Do you mean "can only be set once"?
It's assignable from Ruby simply for the gem's own initialization, but it should never be re-assigned later. Fix: ruby#1079
byroot
force-pushed
the
reject-default-sorting-proc-change
branch
from
September 28, 2026 13:26
5804089 to
2ecb368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's assignable from Ruby simply for the gem's own initialization, but it should never be re-assigned later.
Fix: #1079
@eightbitraptor does that solve your problem?