Repository navigation
fix(assistant): align workspace rails and simplify nested surfaces - #289
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
3285b8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b391d761.document-7hm.pages.dev |
| Branch Preview URL: | https://codex-assistant-layout-contr.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE] — The assistant shares explicit rendered alignment contracts, with regression evidence across sibling views and input modes.
Summary
The assistant title's outer button aligned while its text was inset, and its hover target expanded into unused toolbar space. Subpages accumulated different horizontal and vertical offsets. Align the title text, onboarding copy, content and field frames to one 16px rail; give back navigation an explicit shared column; and keep the title target sized to its content.
Apply the same owner rules across Models, Conversations, Sources and Artifacts, including populated disclosures and artifact import/editor/return states. Narrow headers place the readable translated title above the five actions. Fix coarse-input title compression, clipped keyboard focus outlines and missing group gaps found during rendered acceptance.
Refine History & data into one column of content-sized native secondary buttons. Remove the nested group frame, internal row rules and deletion divider while retaining each button's resting surface. Share the 16px checkbox/icon and 40px text columns across adjacent controls, with an explicit 8px target extension into the owned inline-start gutter. Keep 8px between buttons and 16px before destructive actions; only explicit confirmation uses solid danger fill. Preserve localization sync, 44px targets, hover/press/focus, busy guards, downloads and focus return.
Review the complete pane and record the purpose of each remaining boundary. The panel edge, editable field frames, major section boundary and keyboard focus outlines retain their distinct functions. Acceptance checks shared checkbox/icon/text columns, resting affordance in both themes and real interactions without mandating a decorative group enclosure.
Apply the same boundary audit across complete Models, Sources and Artifacts states. Remove cached-model/disclosure rules and redundant inset, the blanket workspace/artifact command outlines, and ranui cache-command host shadows through public styling hooks. Separate attached sources from search and keep removal beside the title while previews expand. Saved artifacts become flat full-width rows; export, paging, review and revision controls stay quiet, while Attach/Import/Save and explicit deletion confirmation retain their respective roles. Preserve actual picker/input frames, data table relationships, focus, async ownership and all existing state flows.
The companion ran standards and acceptance PR #434 defines the reusable rules. It changes documentation and test examples, so no ranui release or dependency upgrade is required here.
See the layout acceptance record and complete workspace boundary audit with renders. Separate commits retain scope/design, browser acceptance, shared CSS implementation, flat composition and verification records.
Risk Analysis
Design Decisions
Code Concerns
No outstanding actionable findings after review. The coarse-title flex basis and focus-outline clipping found during review were fixed and checked in a fresh production preview.
Verification
pnpm test: 252 files and 6,801 tests passed after the full workspace audit and source action classes. Runtime ownership and logic are unchanged. Earlier coverage details are recorded in the acceptance document.pnpm lint:ts,pnpm format:check,pnpm buildandgit diff --checkpassed; 1,511 immutable evaluation artifacts retained.The first concurrent coverage attempt hit an existing file-read timeout; an isolated complete rerun passed. Full repository browser/Docker execution and native browser zoom were outside this focused run.