Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions frontend/src/components/testing-farm/TestingFarmRun.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,21 @@ export const TestingFarmRun = () => {
</DescriptionListDescription>
<DescriptionListTerm>Pipeline ID</DescriptionListTerm>
<DescriptionListDescription>
<ClipboardCopy
isReadOnly
hoverTip="Copy"
clickTip="Copied"
variant="inline-compact"
<a
href={
data.web_url ||
`https://api.testing-farm.io/v0.1/requests/${data.pipeline_id}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the data.web_url link. Previously, this link was only part of the status field (line 112), but now the Pipeline ID field also contains either the data.web_url link or https://api.testing-farm.io/v0.1/requests/${data.pipeline_id} in case of queued jobs.

I don't find this consistent, and could be a bit confusing for users.

}
>
{data.pipeline_id}
</ClipboardCopy>
<ClipboardCopy
isReadOnly
hoverTip="Copy"
clickTip="Copied"
variant="inline-compact"
>
{data.pipeline_id}
</ClipboardCopy>
</a>
</DescriptionListDescription>
</DescriptionListGroup>
<DescriptionListGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,12 @@ export const TestingFarmRunsTable = () => {
</Td>
<Td dataLabel={columnNames.testResults}>
<strong>
<a href={testing_farm_run.web_url}>
<a
href={
testing_farm_run.web_url ||
`https://api.testing-farm.io/v0.1/requests/${testing_farm_run.pipeline_id}`
}
>
{testing_farm_run.pipeline_id}
</a>
</strong>
Expand Down
Loading