Repository navigation
feat(#527): link queued TF pipeline IDs to API requests endpoint - #552
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
When a Testing Farm job is queued and web_url is not yet populated, the pipeline ID was displayed without a functional link. Now, when web_url is empty, the pipeline ID links to the Testing Farm API requests endpoint so users can check the current state of queued jobs. In TestingFarmRunsTable, the pipeline ID link falls back to the TF API URL when web_url is falsy. In TestingFarmRun, the pipeline ID ClipboardCopy is wrapped in a link that uses the same fallback logic. Closes #527
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
betulependule
left a comment
betulependule
left a comment
Contributor
There was a problem hiding this comment.
Based on my review, I would lean towards the alternative implementation of this issue in #551
| <a | ||
| href={ | ||
| data.web_url || | ||
| `https://api.testing-farm.io/v0.1/requests/${data.pipeline_id}` |
Contributor
There was a problem hiding this comment.
This duplicates the data.web_url link. Previously, this link was only part of the status field (line 112), but now the Pipeline ID field also contains either the data.web_url link or https://api.testing-farm.io/v0.1/requests/${data.pipeline_id} in case of queued jobs.
I don't find this consistent, and could be a bit confusing for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_urlis empty and the pipeline ID had no functional linkweb_urlis empty, the pipeline ID links to the Testing Farm API requests endpoint so users can check the current stateTestingFarmRunsTable) and detail view (TestingFarmRun) are updated with the fallback URL logicChanges
TestingFarmRunsTable.tsx: Pipeline ID<a>tag now usesweb_url || TF API URLinstead of justweb_urlTestingFarmRun.tsx: Pipeline IDClipboardCopyis wrapped in a link that uses the same fallback logic, providing a clickable link in both queued and completed statesTesting
BaseStatusLabel.test.tsxis unrelated)Closes #527
Post-script verification
agent/527-tf-queued-pipeline-link)cea57ba2ebf6bdefc39028d1a9aace4f5427a2a4..HEAD)