Repository navigation
AO3-7550 i18n-ing skins wizard font, skins wizard font size and skins wizard vertical gap help files #5960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ASalbenblatt
wants to merge
9
commits into
otwcode:master
Choose a base branch
from
ASalbenblatt:AO3-7550_i18n-skins-wizard-font,-skins-wizard-font-size-and-skins-wizard-vertical-gap-help-files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−11
Open
AO3-7550 i18n-ing skins wizard font, skins wizard font size and skins wizard vertical gap help files #5960
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
314f585
AO3-7550 i18n-ing skins wizard font, skins wizard font size and skins…
ASalbenblatt 04a8d2e
AO3-7550 Fixing capitalization
ASalbenblatt 4a45631
AO3-7550 Making it so the order of the examples matches the preceding…
ASalbenblatt 62b8c3c
AO3-7550 Making modal titles match old titles
ASalbenblatt 5928ee7
AO3-7550 Fixing a typo
ASalbenblatt ac0299b
AO3-7550 Fixing prefixes and sufixes for translation keys
ASalbenblatt 8f57226
AO3-7550 Preventing repesentations of CSS from being translated
ASalbenblatt da7b276
Merge branch 'AO3-7550_i18n-skins-wizard-font,-skins-wizard-font-size…
ASalbenblatt 1a38090
AO3-7550 Making i18ned text match old text
ASalbenblatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <p><%= t(".default_html", default_fonts_code: tag.code("'Lucida Grande', 'Lucida Sans Unicode', Verdana, Helvetica, sans-serif, 'GNU Unifont'")) %></p> | ||
| <p><%= t(".description") %></p> | ||
| <p><%= t(".single_or_double_quotes_html", double_quote_example: tag.kbd('"Lucida Grande"'), single_quote_example: tag.kbd("'Lucide Sans Unicode'")) %></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <p><%= t(".default_html", one_hundred_percent_code: tag.code("100%")) %></p> | ||
| <p><%= t(".description_html", one_hundred_typed: tag.kbd("100")) %></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <p><%= t(".default_html", default_value_code: tag.code("1.1286em")) %></p> | ||
| <p><%= t(".description") %></p> | ||
| <p><%= t(".examples_html", two_typed: tag.kbd("2"), zero_point_five_typed: tag.kbd("0.5")) %></p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the ancient tag wrangling wisdom of "nothing before something", these two should switch places to be alphabetical please (and in routes.rb as well)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though that would make this list no longer match how the files themselves are automatically ordered in the folder? (due to
_coming before.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point and I had to take a bit to think about it. I think in this case both reasonings are perfectly sensible so I'll leave it up to you what you go for. I'll just force future PRs to match yours so we're consistent 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leave it like this, because I feel like the only reason you'd really go looking through this list is if you were also modifying the files in some way, so I feel like they should match.