[ASalbenblatt]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7550

Purpose

Internationalizes the skins wizard font, skins wizard font size and skins wizard vertical gap help files

Credit

FlyingFalcon they/them

[Bilka2]

Thanks for working on this! I have only some nitpicks

[Bilka2]

Following the ancient tag wrangling wisdom of "nothing before something", these two should switch places to be alphabetical please (and in routes.rb as well)

[ASalbenblatt]

Even though that would make this list no longer match how the files themselves are automatically ordered in the folder? (due to _ coming before .)

[Bilka2]

That's a good point and I had to take a bit to think about it. I think in this case both reasonings are perfectly sensible so I'll leave it up to you what you go for. I'll just force future PRs to match yours so we're consistent 😂

[ASalbenblatt]

I think leave it like this, because I feel like the only reason you'd really go looking through this list is if you were also modifying the files in some way, so I feel like they should match.

[Bilka2]

Thank you!