Repository navigation
docs(site): land on the install section when arriving from another page - #51
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.4.0-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Install in the nav now lands on the install section from every page.
Why
On wide screens, the landing's How section adds its scroll runway (1.6 screen heights) in an effect after mount. Arriving from another page, Next has already scrolled to
#installby then, so the runway pushes the section about 1,440px below where the scroll stopped. Opening/#installdirectly does the same.After the runway is laid out, How now scrolls to the hash target again if the target follows it. This happens on first mount only, so crossing the breakpoint on resize doesn't jump the page.
Checked
/docs,/examplesand/docs/viewersettles at the section's 96px scroll margin, the same as from the landing.