Repository navigation
quest: composable scenes replace canvases; mixes become audio scenes - #57
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
OpenCode Zen returned an error, so this run stopped. If it names your key, plan or balance, fix that with the provider or pick another model.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit 48d5aae. Composable scenes and an explicit Program source are a reasonable simplification, but two planning conflicts need decisions:
- [P2] Define cycle rejection when Program changes (
quest/m0/scenes/scene-source.md:5–8). Program's graph edges change at a cut or transition, not only an edit. If B contains Program while A is live, cutting to B creates Program → B → Program without an edit. Reject dynamic cycles on Cut/Transition and load/undo, including both transition endpoints, or prohibit Program-dependent scenes from entering the switcher. Add this scenario to acceptance tests. - [P2] Reconcile shared rendering with independent activation clocks (
quest/m0/scenes/scene-source.md:20–21). During a transition A → B, both may contain keyframed child C: outgoing A needs its existing animation time while incoming B needs C restarted. One cached texture per scene per frame cannot satisfy both. Define a shared activation policy or cache by scene plus activation context, and test shared animated children across a transition.
Verification: GitHub-only static review of the plans and relevant compositor timing. These are specification conflicts, not runtime reproductions; I did not run tests.

Replaces canvases with composable scenes, settled with the maintainer through
/quest-planon 2026-11-05. #54 is closed in favor of this plan.Quests
quest/m0/multi-canvas.md:program, as a source.<broadcast>/<scene>at its own size, and canvases go away. It carries over feat(studio)!: unlink canvases, record and grade each canvas, and preview only what is seen #54's Health per broadcast, the recording pick, and the preview skip.Decisions
program; program source only.<broadcast>, one switcher; every scene switchable.[mixes]separate.Review
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)