Skip to content

quest: plan uninit, zeroed, nested-pointer, and write_bytes follow-ups - #647

Closed
kixelated wants to merge 1 commit into
mainfrom
quest-plan/ts-unsafe-uninit-followups
Closed

kixelated wants to merge 1 commit into
mainfrom
quest-plan/ts-unsafe-uninit-followups

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Plans four follow-ups as m3 quests in the ts-unsafe epic: three from moq-dev/rust2#639 (Box::new_uninit and new_zeroed for one value) and one from moq-dev/rust2#642 (BufMut on byte slices).

  • [S] Zeroed values beyond one Box: MaybeUninit::zeroed, mem::zeroed, and Box::new_zeroed_slice, reusing feat(ts): translate Box::new_uninit, new_zeroed, write, and assume_init for one value #639's zero-value code.
  • [S] Rc and Arc of an uninitialized value: new_uninit, new_zeroed, the slice forms, and assume_init.
  • [M] A raw pointer into a nested array: &raw mut (*p)[1][0], with arithmetic within the inner array.
  • [S] ptr::write_bytes beyond bytes: integers, floats, and arrays and tuples of them.

Decisions

Decided with the maintainer on 2026-11-07 (/quest-complete):

  • Each goal as written: ✅ plan it (rejected: drop it), for all four.
  • Milestone: ✅ m3, by the standing rule that a std gap with no consumer becomes its own m3 quest.
  • Nested array pointers: ✅ arithmetic within the inner array (rejected: crossing inner arrays as a requirement).
  • write_bytes: ✅ any byte pattern the runtime can build (rejected: zero only).

Validation

quest check passes (53 documents). No overlap was found in the quest tree, in quests deleted in git history, or in open PRs.

(Written by Claude Opus 5.5 with high effort)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Reviewer: Codex, gpt-6.1-sol, medium effort
  • Session: 01a1b678-1b0a-7820-ad32-38d89f74128d, round 1
  • Head: 608b89a
  • Base: origin/main at 049c551
  • Score: 10/10, The specified diff adds four planning documents and their index links, with no actionable defects or executable behavior changes.
  • Findings: none

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Nov 7, 2026

Copy link
Copy Markdown

Pullfrog  | Review this ➔

@kixelated
kixelated marked this pull request as ready for review November 7, 2026 14:47
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c8c5e82-e739-47c7-90b7-dc7afcafc657
Commits

Reviewing files that changed from the base of the PR and between 049c551 and 608b89a.

Files selected for processing: 5

  • quest/m3/ts-unsafe/README.md
  • quest/m3/ts-unsafe/nested-array-pointers.md
  • quest/m3/ts-unsafe/rc-arc-uninit.md
  • quest/m3/ts-unsafe/write-bytes-any.md
  • quest/m3/ts-unsafe/zeroed-values.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit 608b89a against base 049c551.

No actionable findings in this planning-only change. The four new quests have matching epic links and distinct goals. Reusing the existing zero-value machinery, checking Rc/Arc counts and drops, and requiring native differential tests are sensible directions. The nested-pointer plan explicitly bounds its required support to the inner array and requires unsupported crossings to be refused rather than silently miscompiled; the write_bytes plan likewise limits support to representable pointees and includes nonzero byte patterns.

Verification limits: GitHub-only static review of the five changed documents and the epic's pointer/unsafe constraints. There is no implementation to validate here. I did not run quest check or independently verify the claimed exhaustive overlap search across history and open PRs. This is a COMMENT, not an approval.

(Written by review (OpenAI))

@kixelated

Copy link
Copy Markdown
Collaborator Author

Closed on the maintainer's call (2026-11-07): rust2 spends little time on unsafe Rust. Refusing it with a span, requiring safe Rust, is fine, and so is wrapping a common library. The four follow-ups (zeroed values, Rc/Arc uninit, nested array pointers, write_bytes of any pattern) have no consumer, so they stay refused. quest/m3/README.md's Plan records the rule in the tokio sync plan PR.

(Written by Claude Opus 5.5 with high effort)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant