Repository navigation
quest: plan tokio's sync channels in rust2-ts; record that unsafe may stay refused - #648
Conversation
Quest-Claim: 54f667d07727f9fd
The spike's findings: translation reads each import's JS shape from the program wasm-bindgen's macro encodes in a link_section static, since source reading misses the macro_rules!-made imports on the encoder's path. The imports quest is rewritten to it and split: closures, js-sys's futures, and the VideoEncoder test in headless Chromium move to a closures quest. The epic records tokio::sync as a further gap for web-codecs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… stay refused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit a1d4c2b against base 049c551, separating the already reviewed #638 changes at 388b6d4 from this PR's three-document addition.
No actionable findings in the new plan. Mapping mpsc, watch, oneshot, and select support addresses the identified channel dependency without requiring Tokio's unsafe internals to translate. The plan explicitly refuses blocking methods and unrelated synchronization primitives, and calls for differential checks of ordering, closure, and future readiness. The epic links and the newer m3 decision consistently record that unsupported unsafe code may remain refused rather than forcing speculative implementation work.
Verification limits: GitHub-only static documentation review. No runtime implementation is introduced here; I did not execute quest validation, verify the refusal census, or test Tokio/select behavior. This is a COMMENT, not an approval.
(Written by review (OpenAI))
# Conflicts: # quest/m3/ts-wasm-bindgen/README.md
|
quest land watch: the merge queue removed this pull request at a1d4c2b because A person's removal ends the pick: the watcher leaves this pull request alone until a maintainer enqueues it again. (written by quest land watch) |

Summary
mpsc::unbounded_channeland errors throughwatch::channel, read in abiased;tokio::select!. The spike's census counts about 50 refusals there.quest/m3/README.md's Plan: little time goes to unsafe Rust. Refusing it with a span is fine, and so is mapping a common library.Stacked on #638's head (388b6d4, queued). Until that lands, this diff shows #638's quest changes too.
Decisions
mpsc,watch, andoneshot, plusselect!'s support, are mapped into the runtime, ashashbrownandbytesare. Rejected: translating tokio's source (intrusive waiter lists, raw pointers intoUnsafeCells, atomics,process::abort), and mapping only web-codecs' methods.🤖 Generated with Claude Code
(Written by Claude Opus 5.5 with high effort)
Review
Rewritten by
quest reviewafter each round.01a1b687-b5d8-7a31-a686-920eb55cc8ad, round 1The specified diff only updates quest documentation and splits planned work coherently; no actionable defects, missing local link targets, or whitespace errors were found.