Repository navigation
Merged
Conversation
…nd never crash on it
…thout a conflict
mathiasrw
marked this pull request as draft
October 23, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #815
Stacked on #830.
Change
The numbers of #791, the groups and the named groups of #799 are made with
varin front of the--jscode. Code that declared one of those names itself withletorconstdid not run:Now the code of the user is put in a block of its own, so its
letandconstare in their own scope, and it givesfTTagain. The value of a block is the value of its last statement, so the code works as before. A line break goes before the end of the block, so a//comment at the end of the code does not hide it.Tests
test/fix/815.test.jsis new, and its tests withletandconstfail without the fix.yarn test-cipasses.From the review of 23 October.
Follow-up
test/fix/815.test.jsalso covers a cousin withconst($n00), a function named like a number, and thatvar $tstill works. Thevarand comment tests pass without the fix too, as guards.