Repository navigation
Conversation
mathiasrw
marked this pull request as draft
October 23, 2026 13:05
mathiasrw
marked this pull request as ready for review
October 23, 2026 13:17
mathiasrw
added this pull request to stack #841
October 23, 2026 13:56
…nd never crash on it
…thout a conflict
mathiasrw
marked this pull request as draft
October 23, 2026 15:08
…d say the rr_ help shorter
mathiasrw
marked this pull request as ready for review
October 23, 2026 15:13
mathiasrw
removed this pull request from stack #841
October 23, 2026 15:57
mathiasrw
added this pull request to stack #849
October 23, 2026 16:12
mathiasrw
removed this pull request from stack #849
October 23, 2026 16:12
mathiasrw
added this pull request to stack #850
October 23, 2026 16:17
mathiasrw
removed this pull request from stack #850
October 23, 2026 16:47
mathiasrw
added this pull request to stack #853
October 23, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #825
Stacked on #831.
Change
rr_in front:rr_yearfor(?<year>…), andrr_year_has a space at the end. Before it was_year, which could clash with what RexReplace uses itself: a group named_require_broker().--js, a named group can not end with_, asrr_a_would be both the groupa_and the groupawith a space. It is a panic:Without
--jsthere are no variables, so such a name is fine there.The help and the README say
rr_year. The tests of #799 and #815 userr_.Tests
test/fix/825.test.jsis new.yarn test-cipasses.After the review of 24 October
--output-matchthe code is not run, so a group name that ends with_is fine there, and no longer a panic._require, which really clashed: with_in front, its variable with a space was__require_, whichr()uses. It fails without the fix._with--js, also when the code does not use the group.\(?<a_>or[(?<a_>], is fixed in Find named groups with letters that are not ASCII in --js to close #816 #833, which reads the names from the compiled regex.Follow-up
rr_.(?<year>...)gives yourr_year. A named group name can not end with_." The README line is in Update README regarding --quiet, --debug, --simulate, --sort etc. to close #821 #838.test/fix/825.test.jsnow covers names in uppercase, with a number and with$, two names that only differ by case, the cousin with a space, a name next to its$1, that_yearis gone, and the panic fora_,Year_,_andy2_with a file that is not changed. 13 of its 15 tests fail without the fix.