Repository navigation
Conversation
…n's shell, and test two runtimes
# Conflicts: # test/cli/run.sh # test/engine/fix/711.test.js # test/engine/utf8.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #778
Related to #717 and #734.
Change
test/cli/run.shis a short demo: a few examples for each feature, and a combination where it helps. 68 asserts, down from about 200.test/cli/<feature>.test.js. They run the CLI with Bun's shell, so a test reads like the command:sh($`echo -n x | bun ${cli} o x my.file --pipe`)gives{out, err, exit}. Files are made and read withBun.writeandBun.file.test/jstotest/engine. The CLI parts of them moved totest/cli.test/helper.jsis shared by both, and hascliandsh()in place of the oldcli().rexreplacewith Node, and the installedrexreplace-bunwith Bun. Each run checks that the commands are the right build (+bunor not).-vand-halone, and the--bailalias are only inrun.sh.test/cli/global.run.node.shis gone.Good to know
\uescapes, so a value with€,§or an emoji is given as${'…'}.Tests
yarn test-cipasses: the demo on Node and Bun, and 908 Bun tests.