Repository navigation
Conversation
mathiasrw
added this pull request to stack #787
October 23, 2026 04:29
# Conflicts: # test/cli/fix/742.test.js # test/fix/783.test.js
mathiasrw
marked this pull request as draft
October 23, 2026 08:31
# Conflicts: # README.md # devguide.md # test/cli/debug.test.js # test/cli/delimiter.test.js # test/cli/glob-pipe.test.js # test/cli/run.sh # test/engine/encoding.test.js # test/engine/halt.test.js # test/fix/681.test.js # test/fix/683.test.js # test/fix/691.test.js # test/fix/700.test.js # test/fix/703.test.js # test/fix/708.test.js # test/fix/720.test.js # test/fix/728.test.js # test/fix/742.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #783
Stacked on #781.
Change
--halt, wrong flags or too few arguments..fail()handler. The help and the message on stderr are as before, and the stray empty line on stdout is gone.-hexits with 0, as before.rr()intest/helper.jsgives the same codes as the CLI.What breaks
An error in a file gives 2, and a panic or wrong flags give 3. Both were 1.
Tests
yarn test-cipasses: the demo on Node and Bun (now with exit codes 2 and 3), and 922 Bun tests.test/fix/783.test.jsruns the CLI for each code.test/fix/692.test.jsis back: it was deleted in #779 and not moved, so-version,-help,-V,-H,xversion,xhelpand where the help goes were not tested.