Repository navigation
Conversation
mathiasrw
added this pull request to stack #777
October 23, 2026 01:54
mathiasrw
force-pushed
the
fix/711
branch
2 times, most recently
from
October 23, 2026 02:00
e45733b to
2051811
Compare
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #711
Stacked on #773.
Change
--glob-pipe(-g): each line of the piped data is a path or a glob of the files to work on. The lines are used together with the arguments, in the same way: a line that is an existing file is used as it is, and the rest are globbed as one pool (so!works).\nor\r\n. Empty lines are left out, and spaces are kept, as a file name can have them.--null-in: the piped lines are separated by null bytes, like fromfind -print0or--null-out. It needs--glob-pipe.--nullis now--null-out, with--nullas an alias. Neither is released yet.--glob-pipewith--replacement-pipe,--pipeor--js-pipeis an error in the CLI, and a panic in the engine, as the piped data can only be one thing.--glob-pipestdin is read, also when files are given as arguments."type": "GLOBS"for the piped data.Tests
test/js/fix/711.test.js: lines and globs, together with arguments, a line that is a file (A file with glob characters in its name is not found, or other files are changed with it #718),!,\r\nand empty lines, spaces in names,--null-inwith a line break in a name, nothing piped in, the status report and the conflicts.test/cli/run.sh:--glob-pipeand-g, a chain from--null-outinto--glob-pipe --null-in, and the errors for the conflicts and for--null-inwithout--glob-pipe.test/cli/run.sh: null bytes are kept. Piped in and in a file, in place, with--outputand with--output-match --null-out, the null bytes come out where they went in. This is not full binary safety: with the default utf8 encoding, bytes that are not valid UTF-8 become�when a file is changed. For binary data-e latin1keeps every byte.