Repository navigation
Give a ❌ error, not a stack trace, when a path can not be looked at #788
Description
Today
When the file system gives an error while the files are found, the run crashes with a stack trace and not a ❌ error.
> rexreplace foo bar "{a,$(printf 'x%.0s' {1..300})}.md"
node:fs:1746
const stats = binding.stat(
^
Error: ENAMETOOLONG: name too long, stat '{a,xxxx…}.md'
at Object.statSync (node:fs:1746:25)
…> rexreplace foo bar a.md/x
Error: ENOTDIR: not a directory, scandir '…/a.md'The exit code is 1. Seen on main (6ea7b83) with Node 22 and Bun on macOS.
There are two places it comes from:
fs.statSync(file, {throwIfNoEntry: false})infindFiles(src/engine.ts:776).throwIfNoEntryonly covers ENOENT, so ENAMETOOLONG, ENOTDIR (on Bun) and EACCES are thrown.globs.sync()right after it. fast-glob throws on the same errors (ENAMETOOLONG fromlstat, ENOTDIR fromscandiron Node).
--glob-pipe makes this easier to hit, as each piped line goes through findFiles.
Change
- A path that can not be looked at is not a file, so it goes on to be globbed.
- An error from the glob gives a ❌ error (or a panic), like any other problem with the input, and not a stack trace.
- Add a test for both.
Good to know
- The long brace glob also crashed before Use a path that is a file as it is, and only glob the rest, to close #718 #750 (in fast-glob, at 71616d3), so this is not new with Use a path that is a file as it is, and only glob the rest, to close #718 #750. Use a path that is a file as it is, and only glob the rest, to close #718 #750 added the second place.
- fast-glob has
suppressErrors: true, which skips folders it can not read. It is worth looking at, but it would hide the error from the user too.
Activity
Fix error handling for rename to close #788 (#810)