Conversation
rcosta358
changed the title
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).
|
|
||
| - name: Test server | ||
| working-directory: server | ||
| run: mvn -B test |
Collaborator
There was a problem hiding this comment.
The server tests run twice per CI run. This step runs mvn -B test, and the "Build server" step below runs mvn -B package, which goes through the test phase again. Either drop this step and let package run them, or add -DskipTests to the package step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 24 JUnit tests for source-folder selection, Windows-style file URIs, source positions, diagnostic DTOs, and context conversion. Runs server tests in CI.
Validated with Java 21: Maven tests/package, client lint, TypeScript checks, and extension installation.
Closes #129. Based on #138 for the CI workflow.
Generated by Codex.