Conversation
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
Collaborator
There was a problem hiding this comment.
Base branch: this PR targets codex/phase-4-test-base, which has no PR to main and doesn't contain #139 (git merge-base --is-ancestor on #139's branch and phase-4: not an ancestor). Merging here won't get the weekly workflow onto main, and the schedule only runs from the default branch. Once the stack lands, this needs its base changed to main (or to the last PR in the stack), and it should be rebased onto a base that includes #139.
Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds weekly and manual Windows/macOS runs for client and server unit tests plus VS Code stable integration tests. Uses Node 22 and Java 21 without Xvfb; uploads VS Code logs on failure.
Based on the dependency branch containing #141, #142, #145, and #146. The PR adds only the platform workflow.
Validation: Windows and macOS suites passed; local unit tests and extension installation passed.
Closes #134.
Generated by Codex.