Repository navigation
Credit each source on study pages and stop showing CLOSER's logo - #1
Merged
Merged
Conversation
Study pages now show the credit line each source's terms require, one per source in extra_data.source, under the data catalogue cards. The wording comes from the source-terms review (SOURCE_ATTRIBUTION_HANDOFF.md in harmonydiscovery); rows marked "required" are used verbatim. The per-source rules live in src/config/sourceAttribution.ts, keyed by source_id. The attribution objects mirror the shape proposed for /discover/sources, so the API can take this over later. Logos: - CLOSER: no logo. Their terms need prior approval to use it. This covers the catalogue card, the source filter chip and link previews of CLOSER pages, which were showing their favicon full size. - Other sources' catalogue cards use the site favicon from Google's favicon service instead of the logo URLs baked into the index, two of which 404. - logo_approved is false for every source until permissions come in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of harmonydata/meta#10 to the production frontend (harmonydata.ac.uk/search). The cherry-pick applied cleanly; the code is the same as in meta.
What this does
Source credits. Study pages show the credit line each source's terms require, one per source in
extra_data.source, under "Available in Data Catalogs".Logos.
Config. The per-source rules live in
src/config/sourceAttribution.ts, keyed bysource_id. The attribution objects mirror the shape proposed for/discover/sources.Checked
harmonydataweaviate.azureedge.net), 1970 British Cohort Study on/discover:extra_data.sourceandincludedInDataCatalogshape as beta.tscclean.eslintclean on the new files.Merging deploys to GitHub Pages through
deploy-discovery.yml.🤖 Generated with Claude Code