Repository navigation
Deploy only on push to main, one run at a time - #2
Merged
Merged
Conversation
The pull_request closed trigger ran a second deploy alongside the push for every merged PR. The two raced to force-push gh-pages, and one failed. It also ran for PRs closed without merging, which published unmerged code to production. The push trigger already covers merges. A concurrency group now queues deploys so they can't collide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-discovery.ymlran onpull_request: closedas well as on push tomain. That caused two problems:gh-pages. On Credit each source on study pages and stop showing CLOSER's logo #1 the push run failed withcannot lock ref 'refs/heads/gh-pages'. The PR-closed run had published the same merge commit first, so nothing broke, but it will keep producing failed runs.The fix:
pull_requesttrigger. Push tomainalready covers merges.concurrencygroup so any overlapping deploys (push,repository_dispatch, manual) queue instead of colliding.🤖 Generated with Claude Code