Repository navigation
fix: poll notifications with the filter on screen - #480
Open
SanderMuller wants to merge 3 commits into
Open
SanderMuller wants to merge 3 commits into
SanderMuller wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SanderMuller
force-pushed
the
fix/notifications-poll-keeps-filter
branch
from
October 19, 2026 18:21
d86076b to
5749b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notifications page polls every 30 seconds and loads more on scroll. Both requests reuse the current URL, so they send
typeonly when the URL has?type. On a page opened from the nav, the server uses the remembered filter in the cookie. That filter can differ from the chips on screen. Open Notifications on All, pick Replies, then go Back: the page shows All, and the next poll swaps in Replies. A second tab that changes the filter does the same.The poll and
InfiniteScrollnow sendfilters.type, so the list always matches the chips. The cookie still decides the filter when you open the page without?type.The same poll also refreshes the Remotes badge now. The layout turns its count poller off on this page, and the page poll asked only for the notification count. So on mobile, or with the chat dock undocked, the Remotes badge stopped until you left the page.
NotificationPoll.test.tsxchecks both. It fails onproductionand passes with this change. I added it todraft-images.config.tsandtests/tsconfig.json, sobun run test:unitandtest:typescover it.Related: #308 replaces this poll with a sync endpoint, and #300 and #492 replace
draft-images.config.ts. Whichever lands second needs a small rebase.🤖 Generated with Claude Code