Repository navigation
fix: apply only the latest reply request in a thread - #493
Closed
SanderMuller wants to merge 1 commit into
Closed
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SanderMuller
force-pushed
the
fix/thread-replies-latest-wins
branch
from
October 19, 2026 20:44
394f162 to
378df21
Compare
Member
|
Closing this as already implemented (multiple times). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread loads replies in three places. They are the first load,
reload()after a post, delete or undo, andloadUntil()behind the more-replies button and "Show all". Each one writes its result when it arrives, so an older response can overwrite a newer one. For example, if you post a reply while more replies are still loading, the reload shows your reply. Then the late page replaces the list, and your reply is gone until the next reload. Two quick deletes can bring a deleted reply back the same way.Each request now takes an id. Only the latest one writes its page to the list and the reply count, and clears
isLoading.ThreadReplies.test.tsxrunsuseThreadwith fake fetches that resolve out of order. It covers a late page from the more-replies button and two overlapping reloads, which both fail onproduction. A third case checks that the button does not stay on "Loading replies…" when the first-load refetch replaces a request still in flight. I added the test todraft-images.config.tsandtests/tsconfig.json, so the gate runs and type-checks it.I did not reproduce the race in a browser, because it needs two requests in flight at the same time.
#480 adds a line at the same place in
draft-images.config.ts, so whichever lands second needs a one-line rebase.🤖 Generated with Claude Code