Skip to content

fix: prevent image attachments in issue command drafts - #451

Closed
robelsust wants to merge 1 commit into
dev-null-sh:productionfrom
robelsust:fix/issue-command-attachments
Closed

robelsust wants to merge 1 commit into
dev-null-sh:productionfrom
robelsust:fix/issue-command-attachments

Conversation

@robelsust

Copy link
Copy Markdown
Contributor

Typing /bug or /feature hides attachment controls, but pasted and dropped images can still enter the draft. Issue submissions carry text only, so those images are silently omitted.

Disable image attachment paths while an issue command is active, suppress the drop overlay, and prevent rejected file drops from navigating away. Preserve text editing and restore attachments when returning to a commit. Use the same rejection behavior for polls, which also do not accept images.

Validation: two new regression cases fail before the fix and pass afterward; all 13 composer tests pass. The standard frontend tests, TypeScript checks, lint, and client/SSR builds pass. Nine browser scenarios verify both commands, inline/dialog composers, text-only issue payloads, canceling, and normal/scheduled attachments. GitHub submissions were mocked.

@robelsust
robelsust force-pushed the fix/issue-command-attachments branch from 68d1a0b to df40ce0 Compare October 22, 2026 15:52
@hbenabdallah

Copy link
Copy Markdown
Contributor

#501 and #542 go the other way and attach the images to the issue.

@nunomaduro

Copy link
Copy Markdown
Member

Closing as a duplicate of #1159. Thanks for the work on this!

@nunomaduro nunomaduro closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants