Skip to content

feat: allow images and a poll on the same commit - #455

Closed
SanderMuller wants to merge 1 commit into
dev-null-sh:productionfrom
SanderMuller:feat/images-with-polls
Closed

SanderMuller wants to merge 1 commit into
dev-null-sh:productionfrom
SanderMuller:feat/images-with-polls

Conversation

@SanderMuller

@SanderMuller SanderMuller commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

A commit can now have images and a poll together. Before, a commit could have only one of the two.

#114 made them exclusive to keep one attachment per card and to avoid a decision on how a poll and an image grid stack. The card already shows the images first and the poll under them, and the composer preview uses the same order. This PR keeps that layout.

  • The server accepts images together with a poll. The body of a poll is its question, so a poll with images still needs a full body. Images without a poll can still go without a body.
  • In the composer, the image button, paste and drop stay on while a poll is open. "Add poll" stays on while images are attached.
  • Scheduled commits follow the same rules.
  • KNOWLEDGE_BASE.md describes the new rule.
screenshot-1792334529836-5

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nunomaduro

Copy link
Copy Markdown
Member

appreciate this one, really..

but i'm not sure i want it for now, so i'm going to close it and we can review it in the future

@nunomaduro nunomaduro closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants