Repository navigation
Conversation
Member
|
@nunomaduro This PR touches test configuration. Could you take a look? |
Contributor
|
I hit the same gap and was about to open a PR for it, so thanks for this one. It now conflicts with After the rebase, I expect two fixtures to need one more field each. |
Contributor
|
#492 does the same thing (runs the TSX component tests in CI). Worth keeping just one of the two. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bun run test:unitonly selected top-level*.test.tsfiles. A wrapper then started a second test runner for three named TSX suites.That left ten React test files out of the normal unit-test command. The test TypeScript project also included only one TSX suite, so the other files were not type-checked.
Changes
tests/Unit/**/*.test.tsand*.test.tsxfile.tests/unit.config.tsand remove the nested runner.vite-plus/testAPI in every frontend suite.tests/tsconfig.json.No production files or test assertions changed.
Regression proof
Before the fix, I added a deliberate failure to the omitted
CommitThread.test.tsxsuite. The old command stayed green because it did not discover that file.With the unified runner, the same command found and failed the deliberate test. I then removed the sentinel and ran the final checks below.
Verification
bun run test:unit— 16 files, 89 tests passedbun run test:typesbun run test:lintbun run buildcomposer test:lintcomposer test:typescomposer test:type-coverage— 100%git diff --checkThe full
composer test:unitcommand was not run locally because it requires the PostgreSQL extensions and coverage driver provided by GitHub Actions. Its frontend step was run directly asbun run test:unit.Risk
This changes test discovery and test fixtures only. The main expected effect is that CI now runs all frontend unit tests instead of a partial allowlist.