Skip to content

feat(kotlin-sdk)!: reset an outbound contact account's pool and keep its request digest on Android #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
romchornyi wants to merge 1 commit into
base: fix/contact-rebuild-ffi-swift
Choose a base branch
from
+4,854 −12
Draft

feat(kotlin-sdk)!: reset an outbound contact account's pool and keep its request digest on Android #5590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions docs/sdk/sdk-parity-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@
"platform_wallet_manager_shielded_wallet_drain_status": "packages/rs-platform-wallet-ffi/src/shielded_wallet_drain.rs",
"platform_wallet_manager_spv_rescan_filters": "packages/rs-platform-wallet-ffi/src/spv.rs",
"platform_wallet_manager_sync_fault_detected": "packages/rs-platform-wallet-ffi/src/manager.rs",
"platform_wallet_reserve_dashpay_payment_address": "packages/rs-platform-wallet-ffi/src/dashpay.rs",
"platform_wallet_resume_identity_with_existing_asset_lock_signer": "packages/rs-platform-wallet-ffi/src/identity_registration_funded_with_signer.rs",
"platform_wallet_send_dashpay_payment": "packages/rs-platform-wallet-ffi/src/dashpay.rs",
"platform_wallet_sync_contested_dpns_names": "packages/rs-platform-wallet-ffi/src/dpns.rs",
"platform_wallet_token_purchase": "packages/rs-platform-wallet-ffi/src/tokens/purchase.rs",
"platform_wallet_token_transfer": "packages/rs-platform-wallet-ffi/src/tokens/transfer.rs",
Expand Down Expand Up @@ -1690,6 +1692,84 @@
"covers_restart": false
}
]
},
{
"id": "dashpay.outbound_account_rotation",
"title": "A contact's rotated xpub replaces the outbound account's stored pool and is known after a restart",
"area": "persistence",
"shared_apis": [
"platform_wallet_send_dashpay_payment",
"platform_wallet_reserve_dashpay_payment_address"
],
"required_persistence_capabilities": [
"asset_lock_funding_indices",
"atomic_changesets",
"wallet_restore"
],
"hosts": {
"swift": {
"sdk": "supported",
"example_app": "not-applicable",
"restart": "tested",
"reason": null
},
"kotlin": {
"sdk": "supported",
"example_app": "not-applicable",
"restart": "tested",
"reason": null
}
},
"verification": [
{
"host": "shared",
"kind": "unit",
"file": "packages/rs-platform-wallet/src/wallet/identity/network/payments.rs",
"id": "should_know_after_a_relaunch_whether_the_outbound_account_predates_a_rotation",
"command": "cargo test -p platform-wallet --lib should_know_after_a_relaunch_whether_the_outbound_account_predates_a_rotation",
"covers_restart": true
},
{
"host": "shared",
"kind": "unit",
"file": "packages/rs-platform-wallet-ffi/src/persistence.rs",
"id": "should_store_a_replaced_outbound_account_in_order_and_refuse_without_a_reset",
"command": "cargo test -p platform-wallet-ffi --lib should_store_a_replaced_outbound_account_in_order_and_refuse_without_a_reset",
"covers_restart": false
},
{
"host": "swift",
"kind": "unit",
"file": "packages/swift-sdk/SwiftTests/SwiftDashSDKTests/OutboundAccountReplacementPersistenceTests.swift",
"id": "testResetDropsThePreviousXpubsRowsAndKeepsTheirTxos",
"command": "cd packages/swift-sdk && xcodebuild test -scheme SwiftDashSDK -sdk iphonesimulator -destination \"platform=iOS Simulator,name=iPhone 17\" ARCHS=arm64 -only-testing:SwiftDashSDKTests/OutboundAccountReplacementPersistenceTests",
"covers_restart": false
},
{
"host": "swift",
"kind": "unit",
"file": "packages/swift-sdk/SwiftTests/SwiftDashSDKTests/OutboundAccountReplacementPersistenceTests.swift",
"id": "testDigestSurvivesStoreReopenOnTheAccountRowAndFailsClosed",
"command": "cd packages/swift-sdk && xcodebuild test -scheme SwiftDashSDK -sdk iphonesimulator -destination \"platform=iOS Simulator,name=iPhone 17\" ARCHS=arm64 -only-testing:SwiftDashSDKTests/OutboundAccountReplacementPersistenceTests",
"covers_restart": true
},
{
"host": "kotlin",
"kind": "unit",
"file": "packages/kotlin-sdk/sdk/src/test/kotlin/org/dashfoundation/dashsdk/persistence/PlatformWalletPersistenceHandlerTest.kt",
"id": "outboundAccountPoolResetDropsItsRowsAndKeepsTheirTxos",
"command": "cd packages/kotlin-sdk && ./gradlew :sdk:testDebugUnitTest",
"covers_restart": false
},
{
"host": "kotlin",
"kind": "unit",
"file": "packages/kotlin-sdk/sdk/src/test/kotlin/org/dashfoundation/dashsdk/persistence/PlatformWalletPersistenceHandlerTest.kt",
"id": "outboundAccountDigestSurvivesRestartOnTheAccountRowAndFailsClosed",
"command": "cd packages/kotlin-sdk && ./gradlew :sdk:testDebugUnitTest",
"covers_restart": true
}
]
}
]
}
15 changes: 8 additions & 7 deletions packages/kotlin-sdk/PARITY_SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@
# Kotlin/Swift executable parity summary

Audit baseline: `PR #3999 @ 6dbc72a54df72d26eb9c4a014b425d2b95134e4e`
Capabilities tracked: **27**
Capabilities tracked: **28**

## Status counts

| Host | Surface | Supported | Partial | Unsupported | Not applicable |
| --- | --- | ---: | ---: | ---: | ---: |
| Swift | SDK | 16 | 9 | 1 | 1 |
| Swift | Example app | 4 | 12 | 2 | 9 |
| Kotlin | SDK | 13 | 12 | 1 | 1 |
| Kotlin | Example app | 5 | 12 | 1 | 9 |
| Swift | SDK | 17 | 9 | 1 | 1 |
| Swift | Example app | 4 | 12 | 2 | 10 |
| Kotlin | SDK | 14 | 12 | 1 | 1 |
| Kotlin | Example app | 5 | 12 | 1 | 10 |

## Restart coverage

| Host | Tested | Required | Not applicable |
| --- | ---: | ---: | ---: |
| Swift | 1 | 8 | 18 |
| Kotlin | 4 | 6 | 17 |
| Swift | 2 | 8 | 18 |
| Kotlin | 5 | 6 | 17 |

## Capability status

Expand Down Expand Up @@ -51,6 +51,7 @@ Capabilities tracked: **27**
| `persistence.pending_identity_key_repair` | unsupported / unsupported / not_applicable | supported / not-applicable / tested |
| `errors.signing_key_unavailable_discriminator` | supported / not-applicable / not_applicable | supported / not-applicable / not_applicable |
| `shielded.core_wallet_drain` | supported / unsupported / tested | unsupported / unsupported / not_applicable |
| `dashpay.outbound_account_rotation` | supported / not-applicable / tested | supported / not-applicable / tested |

Source: [`docs/sdk/sdk-parity-manifest.json`](../../docs/sdk/sdk-parity-manifest.json).
Detailed legacy view mapping remains in [`PARITY.md`](PARITY.md), but its manual totals are not authoritative.
Loading
Loading