Repository navigation
feat(kotlin-sdk)!: reset an outbound contact account's pool and keep its request digest on Android - #5590
Draft
romchornyi wants to merge 1 commit into
Draft
feat(kotlin-sdk)!: reset an outbound contact account's pool and keep its request digest on Android#5590romchornyi wants to merge 1 commit into
romchornyi wants to merge 1 commit into
Conversation
…est digest on Android Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WYhtAUUCkvoBmp19LA8Z31
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
🕓 Review not started yet because this PR is a draft.
Commit 55dc3dd. Normal review starts when eligible; priority review starts as soon as a slot is available. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic explanation
What this does: This does the same for the Android host that #5589 does for iOS:
Value: On Android, a contact who sends a new key gets a clean account, and a restart knows whether the account is current.
Risks: Low to medium.
16.json), which every version commits. The v15 PR added a15.jsonof the same size.Stack (review and merge in order):
Issue being fixed or feature implemented
Part 3 of the stack started in #5587.
CoreAddressEntityby address. When a contact rotated, it kept the previous xpub's rows beside the new ones.What was done?
rs-unified-sdk-jni
FfiSmokeTestverification table.kotlin-sdk
NativePersistenceBridgegets three new methods:onResetAccountAddressPool,onPersistAccountXpubDigestandonLoadAccountXpubDigest.deleteByAccount;AccountEntity.encryptedXpubDigest, Room v16 withMIGRATION_15_16, and the exported16.json.docs: parity manifest entry
dashpay.outbound_account_rotation, with a regeneratedPARITY_SUMMARY.md.How Has This Been Tested?
cargo test -p rs-unified-sdk-jni --all-features(53), including slot wiring by overrides. Clippy is clean../gradlew :sdk:testDebugUnitTest:PlatformWalletPersistenceHandlerTest. The reset keeps TXOs and requires the account row; the digest survives a restart and can be cleared.DashDatabaseMigrationTest.migrate15To16AddsOutboundAccountDigestColumn, with the 4→latest and 1→latest chains extended to v16. These compile (:sdk:compileDebugAndroidTestKotlin) but were not run here, because they need a device.python3 scripts/check_sdk_parity_manifest.pypasses.Breaking Changes
NativePersistenceBridgesubclasses that persist pools must overrideonResetAccountAddressPool, or replacement rounds fail.Checklist:
structure.rs, regeneratedgrovedb-structure.json, and checked the structure viewer link posted on this pull requestFor repository code-owners and collaborators only
🤖 Generated with Claude Code